From: "shekhar, chandra" <x0044955@ti.com>
To: Misael Lopez <mesak82@gmail.com>, "Gadiyar, Anand" <gadiyar@ti.com>
Cc: linux-omap@vger.kernel.org, "Pandita, Vikram" <vikram.pandita@ti.com>
Subject: Re: [PATCH][OMAPZOOM] OMAP3: Fix handling of McBSP registers XCCR and RCCR for OMAP2430/34xx
Date: Fri, 21 Nov 2008 12:03:41 +0530 [thread overview]
Message-ID: <002601c94ba3$193117d0$LocalHost@wipultra806> (raw)
In-Reply-To: 76fbac300811202225m53237b1cq7dde99d5ace9a62a@mail.gmail.com
----- Original Message -----
From: "Misael Lopez" <mesak82@gmail.com>
To: "Gadiyar, Anand" <gadiyar@ti.com>
Cc: <linux-omap@vger.kernel.org>; "Pandita, Vikram" <vikram.pandita@ti.com>
Sent: Friday, November 21, 2008 11:55 AM
Subject: Re: [PATCH][OMAPZOOM] OMAP3: Fix handling of McBSP registers XCCR and
RCCR for OMAP2430/34xx
>> > @@ -403,8 +408,10 @@ struct omap_mcbsp_reg_cfg {
>> > u16 rcerh;
>> > u16 xcerg;
>> > u16 xcerh;
>> > +#if defined(CONFIG_ARCH_OMAP2430) || defined(CONFIG_ARCH_OMAP34XX)
>> > u16 xccr;
>> > u16 rccr;
>> > +#endif
>> > };
>>
>> Won't this cause a compilation break on non-2430/34xx platforms
>> because you refer to these variables below?
> True... I didn't consider that. Then for non-2430/34xx platforms,
> having those registers in the structure but avoiding to write to them
> is enough, correct? or any other alternative?
Since you write those registers conditionally for 2430/34xx, i guess removing
ifdef should do..
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2008-11-21 6:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 4:31 [PATCH][OMAPZOOM] OMAP3: Fix handling of McBSP registers XCCR and RCCR for OMAP2430/34xx mesak82
2008-11-21 6:06 ` Gadiyar, Anand
2008-11-21 6:25 ` Misael Lopez
2008-11-21 6:33 ` shekhar, chandra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002601c94ba3$193117d0$LocalHost@wipultra806' \
--to=x0044955@ti.com \
--cc=gadiyar@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=mesak82@gmail.com \
--cc=vikram.pandita@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox