From: "Girish" <girishsg@ti.com>
To: 'Kyungmin Park' <kyungmin.park@samsung.com>,
linux-omap-open-source@linux.omap.com
Subject: RE: [RFC][PATCH] ARM: OMAP: Always enable the R/W access to allinitiators in sram
Date: Mon, 26 Nov 2007 21:18:34 +0530 [thread overview]
Message-ID: <003401c83043$ce6385b0$988818ac@ent.ti.com> (raw)
In-Reply-To: <20071126020738.GA32424@party>
>-----Original Message-----
>From: linux-omap-open-source-bounces@linux.omap.com
>[mailto:linux-omap-open-source-bounces@linux.omap.com] On
>Behalf Of Kyungmin Park
>Sent: Monday, November 26, 2007 7:38 AM
>To: linux-omap-open-source@linux.omap.com
00
>
>Also we get the 'type' from CONTROL_STATUS(0x2F0) instead
>previous (0x2F8).
>
>Please let me know what is the right way.
>
It seems like the CONTROL_STATUS which was defined earlier in omap[2/3]4xx.h has been moved somewhere else.
Well, just a quick look it seems that CONTROL_STATUS definition has been moved to asm/arch/control.h, here CONTROL_STATUS has been
defined only for 3430 and doesn't handle for 24xx, so 3430 CONTROL_STATUS value is getting included for 24xx. This is breaking code
on 24xx guess.
Regards,
girish
>Any comments are welcome.
>
>Thank you,
>Kyungmin Park
>---
>diff --git a/arch/arm/plat-omap/sram.c
>b/arch/arm/plat-omap/sram.c index dd8dc04..f1e0af3 100644
>--- a/arch/arm/plat-omap/sram.c
>+++ b/arch/arm/plat-omap/sram.c
>@@ -97,15 +97,16 @@ static int is_sram_locked(void)
> type = ctrl_read_reg(CONTROL_STATUS) &
>TYPE_MASK; #endif
>
>- if (type == GP_DEVICE) {
>- /* RAMFW: R/W access to all initiators for all
>qualifier sets */
>- if (cpu_is_omap242x()) {
>- __raw_writel(0xFF, VA_REQINFOPERM0); /*
>all q-vects */
>- __raw_writel(0xCFDE, VA_READPERM0); /*
>all i-read */
>- __raw_writel(0xCFDE, VA_WRITEPERM0); /*
>all i-write */
>- }
>+ /* RAMFW: R/W access to all initiators for all qualifier sets */
>+ if (cpu_is_omap242x()) {
>+ __raw_writel(0xFF, VA_REQINFOPERM0); /* all q-vects */
>+ __raw_writel(0xCFDE, VA_READPERM0); /* all i-read */
>+ __raw_writel(0xCFDE, VA_WRITEPERM0); /* all i-write */
>+ }
>+
>+ if (type == GP_DEVICE)
> return 0;
>- } else
>+ else
> return 1; /* assume locked with no PPA or
>security driver */ }
>
>diff --git a/include/asm-arm/arch-omap/control.h
>b/include/asm-arm/arch-omap/control.h
>index 5f42725..9f9075e 100644
>--- a/include/asm-arm/arch-omap/control.h
>+++ b/include/asm-arm/arch-omap/control.h
>@@ -38,6 +38,7 @@
> #define CONTROL_DEVCONF0 (CONTROL_GENERAL + 0x04)
> #define CONTROL_DEVCONF1 (CONTROL_GENERAL +
>0x68) /* > 242x */
> #define CONTROL_STATUS (CONTROL_GENERAL + 0x80)
>+#define CONTROL_STAT (CONTROL_GENERAL + 0x88)
>
>
> /*
>_______________________________________________
>Linux-omap-open-source mailing list
>Linux-omap-open-source@linux.omap.com
>http://linux.omap.com/mailman/listinfo/linux-omap-open-source
>
prev parent reply other threads:[~2007-11-26 15:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-26 2:07 [RFC][PATCH] ARM: OMAP: Always enable the R/W access to all initiators in sram Kyungmin Park
2007-11-26 11:07 ` Paul Walmsley
2007-11-26 17:02 ` Woodruff, Richard
2007-11-26 18:51 ` Tony Lindgren
2007-11-27 6:35 ` Kyungmin Park
2007-11-27 9:38 ` Paul Walmsley
2007-11-26 15:48 ` Girish [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003401c83043$ce6385b0$988818ac@ent.ti.com' \
--to=girishsg@ti.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox