From: "Madhusudhan" <madhu.cr@ti.com>
To: "'Shilimkar, Santosh'" <santosh.shilimkar@ti.com>,
'kishore kadiyala' <kishorek.kadiyala@gmail.com>
Cc: "'S, Venkatraman'" <svenkatr@ti.com>,
linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-arm-kernel@lists.arm.linux.org.uk,
'Adrian Hunter' <adrian.hunter@nokia.com>,
"'Kadiyala, Kishore'" <kishore.kadiyala@ti.com>,
'Tony Lindgren' <tony@atomide.com>
Subject: RE: [PATCH v8 2/2] omap hsmmc: adaptation of sdma descriptor autoloading feature
Date: Thu, 6 May 2010 11:20:17 -0500 [thread overview]
Message-ID: <004501caed38$03e7b9f0$544ff780@am.dhcp.ti.com> (raw)
In-Reply-To: <EAF47CD23C76F840A9E7FCE10091EFAB02C5387482@dbde02.ent.ti.com>
> -----Original Message-----
> From: Shilimkar, Santosh [mailto:santosh.shilimkar@ti.com]
> Sent: Thursday, May 06, 2010 4:39 AM
> To: kishore kadiyala
> Cc: S, Venkatraman; linux-omap@vger.kernel.org; linux-mmc@vger.kernel.org;
> linux-arm-kernel@lists.arm.linux.org.uk; Chikkature Rajashekar,
> Madhusudhan; Adrian Hunter; Kadiyala, Kishore; Tony Lindgren
> Subject: RE: [PATCH v8 2/2] omap hsmmc: adaptation of sdma descriptor
> autoloading feature
>
> > -----Original Message-----
> > From: kishore kadiyala [mailto:kishorek.kadiyala@gmail.com]
> > Sent: Thursday, May 06, 2010 2:32 PM
> > To: Shilimkar, Santosh
> > Cc: S, Venkatraman; linux-omap@vger.kernel.org; linux-
> mmc@vger.kernel.org; linux-arm-
> > kernel@lists.arm.linux.org.uk; Chikkature Rajashekar, Madhusudhan;
> Adrian Hunter; Kadiyala, Kishore;
> > Tony Lindgren
> > Subject: Re: [PATCH v8 2/2] omap hsmmc: adaptation of sdma descriptor
> autoloading feature
> >
> > <<snip>>
> >
> > >> I am not clear about the method. The board files export the
> > >> omap_mmc_platform_data.
> > >> Does it imply that all board files have to change and export
> > >> the capability so that it can be queried ?
> > > No. You don't have to modify the board files. This would need
> > > change in devices.c which common for all omap boards.
> > >
> > > I don't have a strong opinion on this point but just put forth an
> > > alternate way to avoid such SOC specific check in drivers.
> > > You can take call on this
> >
> > Agree. How about adding a flag in hsmmc.h & omap_mmc_platform_data,
> > that would take care of SDMA & SDMA_DLAOD in the driver instead going
> > with SOC check .
>
> Good idea Kishore.
> Venkat,
> Can you do what kishore is suggesting.
>
omap_mmc_platform_data is MMC specific platform data. Why add a SDMA
specific feature capability into it? Even though you add it there, you will
still need to have a cpu check before that can be set in a common code.
> Regards,
> Santosh
next prev parent reply other threads:[~2010-05-06 16:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-29 17:35 [PATCH v8 2/2] omap hsmmc: adaptation of sdma descriptor autoloading feature Venkatraman S
2010-05-05 9:32 ` Shilimkar, Santosh
2010-05-05 16:19 ` Venkatraman S
2010-05-05 17:21 ` Madhusudhan
2010-05-06 7:49 ` Shilimkar, Santosh
2010-05-06 8:05 ` Shilimkar, Santosh
2010-05-06 8:56 ` Venkatraman S
2010-05-06 9:28 ` Shilimkar, Santosh
2010-05-06 9:02 ` kishore kadiyala
2010-05-06 9:38 ` Shilimkar, Santosh
2010-05-06 16:20 ` Madhusudhan [this message]
2010-05-07 4:52 ` Shilimkar, Santosh
2010-05-07 16:59 ` Madhusudhan
2010-05-07 19:26 ` Nishanth Menon
2010-05-08 0:43 ` Madhusudhan
2010-05-09 10:51 ` Venkatraman S
2010-05-09 16:06 ` Nishanth Menon
2010-05-10 12:31 ` Venkatraman S
2010-05-10 13:09 ` Nishanth Menon
2010-05-14 18:43 ` Venkatraman S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004501caed38$03e7b9f0$544ff780@am.dhcp.ti.com' \
--to=madhu.cr@ti.com \
--cc=adrian.hunter@nokia.com \
--cc=kishore.kadiyala@ti.com \
--cc=kishorek.kadiyala@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=svenkatr@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).