McSPI interfaces in newer kernel

McSPI interfaces in newer kernel

[Meng Hu]

Hi

I am trying to jump from a 2.6.10 montavista kernel to a 2.6.21 one
for OMAP2430.
There are some patches from MonvaVista(originally provided by TI) for
the 2.6.10 kernel which provides some McSPI  implementations, e.g.
drivers/ssi/omap-mcspi.c

I found that these files are not in my 2.6.21 kernel and neither in
the upstream omap linux tree.
Is this because the upstream kernel only contains a small set of omap
drivers OR these old mscpi drivers are replaced by sth. else?
Should I port these files by myself? or change my other drivers to use
the new interfaces. (I am porting a touchscreen driver which heavily
relies on the old mscpi drivers)

Any information would be appreciated!

- Meng

Re: McSPI interfaces in newer kernel

[Kevin Hilman]

"Meng Hu" <meng.hu@gmail.com> writes:

> I am trying to jump from a 2.6.10 montavista kernel to a 2.6.21 one
> for OMAP2430.
> There are some patches from MonvaVista(originally provided by TI) for
> the 2.6.10 kernel which provides some McSPI  implementations, e.g.
> drivers/ssi/omap-mcspi.c
>
> I found that these files are not in my 2.6.21 kernel and neither in
> the upstream omap linux tree.

For the MV 2.6.21-based kernel, we moved from using the TI SPI driver
to the upstream driver (drivers/spi/omap2_mcspi.c)

> Is this because the upstream kernel only contains a small set of omap
> drivers OR these old mscpi drivers are replaced by sth. else?

The "old" driver you're referring to was never upstream, it's only in
the TI kernel (and re-used in the MV kernel.)  For the MV 2.6.21-based
kernel, since there was an upstream driver, we moved to the upstream
driver.

There are many drivers/features which are in the TI kernels which are
not in the upstream kernels.  Feel free to help us all remedy that.
Patches are welcome.  :)

> Should I port these files by myself? or change my other drivers to use
> the new interfaces. (I am porting a touchscreen driver which heavily
> relies on the old mscpi drivers)

I would recommend you use the new driver.  If there is any
functionality in the older driver that is not in the newer one, I
recommend you report it here, preferably with a patch that adds it to
the new driver.  :)

Kevin

Re: McSPI interfaces in newer kernel

[Meng Hu]

Thank you, Kevin.
With the MontaVista Mobilinux 5.0 release, should I expect specific
patches for Omap2430 like those for Mobilinux 4.1?
I had to port a few things from the old kernel patches to make the new
kernel work(Mostly OMAP2430-specific stuff)

For the new McSPI interface, I am not sure if they are missing any
functionality for now.
I actually ported the old TI McSPI interfaces to the new kernel and
they seem to work fine.
I may post an update if we get a chance to implement the touchscreen
drivers using the new McSPI interfaces.

-Meng

On Dec 11, 2007 1:59 PM, Kevin Hilman <khilman@mvista.com> wrote:
> "Meng Hu" <meng.hu@gmail.com> writes:
>
> > I am trying to jump from a 2.6.10 montavista kernel to a 2.6.21 one
> > for OMAP2430.
> > There are some patches from MonvaVista(originally provided by TI) for
> > the 2.6.10 kernel which provides some McSPI  implementations, e.g.
> > drivers/ssi/omap-mcspi.c
> >
> > I found that these files are not in my 2.6.21 kernel and neither in
> > the upstream omap linux tree.
>
> For the MV 2.6.21-based kernel, we moved from using the TI SPI driver
> to the upstream driver (drivers/spi/omap2_mcspi.c)
>
> > Is this because the upstream kernel only contains a small set of omap
> > drivers OR these old mscpi drivers are replaced by sth. else?
>
> The "old" driver you're referring to was never upstream, it's only in
> the TI kernel (and re-used in the MV kernel.)  For the MV 2.6.21-based
> kernel, since there was an upstream driver, we moved to the upstream
> driver.
>
> There are many drivers/features which are in the TI kernels which are
> not in the upstream kernels.  Feel free to help us all remedy that.
> Patches are welcome.  :)
>
> > Should I port these files by myself? or change my other drivers to use
> > the new interfaces. (I am porting a touchscreen driver which heavily
> > relies on the old mscpi drivers)
>
> I would recommend you use the new driver.  If there is any
> functionality in the older driver that is not in the newer one, I
> recommend you report it here, preferably with a patch that adds it to
> the new driver.  :)
>
> Kevin
>

RE: McSPI interfaces in newer kernel

[Girish]

 

>-----Original Message-----
>From: linux-omap-open-source-bounces@linux.omap.com 
>[mailto:linux-omap-open-source-bounces@linux.omap.com] On 
>Behalf Of Meng Hu

>Should I port these files by myself? or change my other 
>drivers to use the new interfaces. (I am porting a touchscreen 
>driver which heavily relies on the old mscpi drivers)
You can very well use the SPI driver which is in upstream and further you can add any specific functionality needed on top of this.
Guess, the old SPI driver doesn't interface with SPI framework, well on which OMAP you are working?

-Girish
_______________________________________________
>Linux-omap-open-source mailing list
>Linux-omap-open-source@linux.omap.com
>http://linux.omap.com/mailman/listinfo/linux-omap-open-source
>

Re: McSPI interfaces in newer kernel

[Meng Hu]

On Dec 12, 2007 9:10 AM, Girish <girishsg@ti.com> wrote:
>
>
> >-----Original Message-----
> >From: linux-omap-open-source-bounces@linux.omap.com
> >[mailto:linux-omap-open-source-bounces@linux.omap.com] On
> >Behalf Of Meng Hu
>
> >Should I port these files by myself? or change my other
> >drivers to use the new interfaces. (I am porting a touchscreen
> >driver which heavily relies on the old mscpi drivers)
> You can very well use the SPI driver which is in upstream and further you can add any specific functionality needed on top of this.
> Guess, the old SPI driver doesn't interface with SPI framework, well on which OMAP you are working?

Hi, Girish
I am working on an OMAP2430 board, not the SDP though.
The wierd thing is, the new upstream SPI driver fails on my board.
Here are the kernel messages:
---omap2_mcspi_init---
omap2_mcspi_probe 1
omap2_mcspi: probe of omap2_mcspi.1 failed with error -2
omap2_mcspi_probe 2
omap2_mcspi: probe of omap2_mcspi.2 failed with error -2

Any idea about this?

On the other hand, I ported the old TI SPI drivers to the new kernel
and they seem to work.
And my 2046 touchscreen driver works fine with the old TI SPI drivers.
There might be potential problems. I don't know.

-Meng


>
> -Girish
> _______________________________________________
> >Linux-omap-open-source mailing list
> >Linux-omap-open-source@linux.omap.com
> >http://linux.omap.com/mailman/listinfo/linux-omap-open-source
> >
>
>

RE: McSPI interfaces in newer kernel

[Girish]

 

>-----Original Message-----
>From: Meng Hu [mailto:meng.hu@gmail.com] 
>Sent: Thursday, December 13, 2007 5:24 AM
>To: Girish
>Cc: Linux-omap-open-source@linux.omap.com

>Hi, Girish
>I am working on an OMAP2430 board, not the SDP though.
>The wierd thing is, the new upstream SPI driver fails on my board.
>Here are the kernel messages:
>---omap2_mcspi_init---
>omap2_mcspi_probe 1
>omap2_mcspi: probe of omap2_mcspi.1 failed with error -2 
>omap2_mcspi_probe 2
>omap2_mcspi: probe of omap2_mcspi.2 failed with error -2
>
>Any idea about this?

Omap2_mcspi should be working fine on 2430, check with your clock enabling, if it's causing the break.

>
>On the other hand, I ported the old TI SPI drivers to the new 
>kernel and they seem to work.
>And my 2046 touchscreen driver works fine with the old TI SPI drivers.
>There might be potential problems. I don't know.

You might want to use ads7846 touchscreen driver which is in upstream, 2046 is a newer ads7846 silicon.

-Girish
>> _______________________________________________
>> >Linux-omap-open-source mailing list
>> >Linux-omap-open-source@linux.omap.com
>> >http://linux.omap.com/mailman/listinfo/linux-omap-open-source
>> >
>>
>>
>