RE: [RFC/PATCH] BQ27000/BQ27200 battery monitoring driver for OMAP34xx

["Madhusudhan Chikkature Rajashekar" <madhu.cr@ti.com>]

 

> -----Original Message-----
> From: Felipe Balbi [mailto:me@felipebalbi.com] 
> Sent: Monday, April 28, 2008 5:17 PM
> To: Madhusudhan Chikkature Rajashekar
> Cc: Tony Lindgren; linux-omap@vger.kernel.org
> Subject: RE: [RFC/PATCH] BQ27000/BQ27200 battery monitoring 
> driver for OMAP34xx
> 
> 
> 
> On Mon, 28 Apr 2008 17:11:51 +0530, "Madhusudhan Chikkature 
> Rajashekar"
> <madhu.cr@ti.com> wrote:
> > Hi Felipe,
> > 
> > Thanks for the comments. I will fix them and resend the patch.
> > 
> > Please note my view on the below point.
> > 
> >> > -	pdev = platform_device_alloc("omap-bq2700-battery", id);
> >> > +	pdev = platform_device_alloc("bq27000-bat", id);
> >>
> >> do you really need to change the name here?
> >> It seems that this change doesn't belong to this patch.
> > 
> > I will make this as a separate patch.As BQ27000 chip is not omap
> specific,
> > I guess the above name is not correct. Hence I intend to make that
> change.
> 
> Ok, works for me :-)
> 
> I guess bq2700-battery is ok, just remove omap- from the 
> previous name??
Yes. I will correct the name and resend the patch. I will send this one as a separate patch and followed by it will
be the battery driver patch.

> 
> 
> -- 
> Best Regards,
> 
> Felipe Balbi
> http://felipebalbi.com
> me@felipebalbi.com
> 
>