From: "Girish S G" <girishsg@ti.com>
To: Trilok Soni <soni.trilok@gmail.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM:OMAP2: irda support 3430
Date: Thu, 3 Jul 2008 15:01:41 +0530 [thread overview]
Message-ID: <006301c8dcef$9b362310$5cf6180a@ent.ti.com> (raw)
In-Reply-To: 5d5443650807030158o728c1d85p5062525d9c2a7a1e@mail.gmail.com
----- Original Message -----
From: "Trilok Soni" <soni.trilok@gmail.com>
>> +static struct omap_irda_config irda_data = {
>> + .transceiver_cap = IR_SIRMODE | IR_MIRMODE | IR_FIRMODE,
>> + .transceiver_mode = transceiver_mode,
>> + .select_irda = select_irda,
>
>
> Please rename this hooks to 3430sdp_transceiver_mode and
> 3430sdp_select_irda. Check board_h4.c for example.
>
I think it can be made irda_transceiver_mode/irda_select. And, as this is in 3430 board file, prefixing it with 3430sdp serves no
purpose i guess.
>> + .rx_channel = OMAP24XX_DMA_UART3_RX,
>> + .tx_channel = OMAP24XX_DMA_UART3_TX,
>> + .dest_start = OMAP_UART3_BASE,
>> + .src_start = OMAP_UART3_BASE,
>> + .tx_trigger = OMAP24XX_DMA_UART3_TX,
>> + .rx_trigger = OMAP24XX_DMA_UART3_RX,
>> +};
>
> Actually rx_channel to rx_trigger are not platform data and it is long
> pending cleanup. It would great if we can convert this to
> platform_resource, as it is chip specific not board specific.
>
Yes, I agree.
-girish
next prev parent reply other threads:[~2008-07-03 11:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 6:45 [PATCH 2/2] ARM:OMAP2: irda support 3430 Girish. S. G.
2008-07-03 8:58 ` Trilok Soni
2008-07-03 9:31 ` Girish S G [this message]
2008-07-03 9:35 ` Trilok Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='006301c8dcef$9b362310$5cf6180a@ent.ti.com' \
--to=girishsg@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=soni.trilok@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox