[PATCH v6 4/7] omap3: pm: changing vdd0_/vdd1_ to vdd1_/vdd2_ in VC param structure

[PATCH v6 4/7] omap3: pm: changing vdd0_/vdd1_ to vdd1_/vdd2_ in VC param structure

[Lesly A M]

Rename vdd0_/vdd1_ to vdd1_/vdd2_ in VC param structure.

Signed-off-by: Lesly A M <x0080970@ti.com>
Cc: Nishanth Menon <nm@ti.com>
Cc: David Derrick <dderrick@ti.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>
---
 arch/arm/mach-omap2/voltage.c |   34 +++++++++++++++++-----------------
 arch/arm/mach-omap2/voltage.h |   10 +++++-----
 2 files changed, 22 insertions(+), 22 deletions(-)

diff --git a/arch/arm/mach-omap2/voltage.c b/arch/arm/mach-omap2/voltage.c
index f4069db..1c3f9ed 100644
--- a/arch/arm/mach-omap2/voltage.c
+++ b/arch/arm/mach-omap2/voltage.c
@@ -147,14 +147,14 @@ struct __initdata prm_setup_vc omap3430_vc_config = {
 		.voltoffset = 0x32,
 	},
 	/* VC COMMAND VALUES for VDD1/VDD2 */
-	.vdd0_on = 0x30,        /* 1.2v */
-	.vdd0_onlp = 0x20,      /* 1.0v */
-	.vdd0_ret = 0x1e,       /* 0.975v */
-	.vdd0_off = 0x00,       /* 0.6v */
-	.vdd1_on = 0x2c,        /* 1.15v */
+	.vdd1_on = 0x30,        /* 1.2v */
 	.vdd1_onlp = 0x20,      /* 1.0v */
-	.vdd1_ret = 0x1e,       /* .975v */
+	.vdd1_ret = 0x1e,       /* 0.975v */
 	.vdd1_off = 0x00,       /* 0.6v */
+	.vdd2_on = 0x2c,        /* 1.15v */
+	.vdd2_onlp = 0x20,      /* 1.0v */
+	.vdd2_ret = 0x1e,       /* 0.975v */
+	.vdd2_off = 0x00,       /* 0.6v */
 };
 
 /*
@@ -178,14 +178,14 @@ struct __initdata prm_setup_vc omap3630_vc_config = {
 		.voltoffset = 0x32,
 	},
 	/* VC COMMAND VALUES for VDD1/VDD2 */
-	.vdd0_on = 0x28,	/* 1.1v */
-	.vdd0_onlp = 0x20,	/* 1.0v */
-	.vdd0_ret = 0x13,	/* 0.83v */
-	.vdd0_off = 0x00,	/* 0.6v */
-	.vdd1_on = 0x2B,	/* 1.1375v */
+	.vdd1_on = 0x28,	/* 1.1v */
 	.vdd1_onlp = 0x20,	/* 1.0v */
 	.vdd1_ret = 0x13,	/* 0.83v */
 	.vdd1_off = 0x00,	/* 0.6v */
+	.vdd2_on = 0x2B,	/* 1.1375v */
+	.vdd2_onlp = 0x20,	/* 1.0v */
+	.vdd2_ret = 0x13,	/* 0.83v */
+	.vdd2_off = 0x00,	/* 0.6v */
 };
 
 static struct prm_setup_vc vc_config;
@@ -279,17 +279,17 @@ static void __init init_voltagecontroller(void)
 			VC_VOLRA0_SHIFT));
 
 	voltage_write_reg(vc_reg.cmdval0_reg,
-			(vc_config.vdd0_on << VC_CMD_ON_SHIFT) |
-			(vc_config.vdd0_onlp << VC_CMD_ONLP_SHIFT) |
-			(vc_config.vdd0_ret << VC_CMD_RET_SHIFT) |
-			(vc_config.vdd0_off << VC_CMD_OFF_SHIFT));
-
-	voltage_write_reg(vc_reg.cmdval1_reg,
 			(vc_config.vdd1_on << VC_CMD_ON_SHIFT) |
 			(vc_config.vdd1_onlp << VC_CMD_ONLP_SHIFT) |
 			(vc_config.vdd1_ret << VC_CMD_RET_SHIFT) |
 			(vc_config.vdd1_off << VC_CMD_OFF_SHIFT));
 
+	voltage_write_reg(vc_reg.cmdval1_reg,
+			(vc_config.vdd2_on << VC_CMD_ON_SHIFT) |
+			(vc_config.vdd2_onlp << VC_CMD_ONLP_SHIFT) |
+			(vc_config.vdd2_ret << VC_CMD_RET_SHIFT) |
+			(vc_config.vdd2_off << VC_CMD_OFF_SHIFT));
+
 	voltage_write_reg(vc_ch_conf_reg, VC_CMD1 | VC_RAV1);
 
 	voltage_write_reg(vc_i2c_cfg_reg, VC_MCODE_SHIFT | VC_HSEN);
diff --git a/arch/arm/mach-omap2/voltage.h b/arch/arm/mach-omap2/voltage.h
index f8462c3..04c3bdf 100644
--- a/arch/arm/mach-omap2/voltage.h
+++ b/arch/arm/mach-omap2/voltage.h
@@ -28,15 +28,15 @@ struct prm_setup_vc {
 /* CLK & VOLT SETUPTIME for OFF */
 	struct setuptime_vc off;
 /* PRM_VC_CMD_VAL_0 specific bits */
-	u16 vdd0_on;
-	u16 vdd0_onlp;
-	u16 vdd0_ret;
-	u16 vdd0_off;
-/* PRM_VC_CMD_VAL_1 specific bits */
 	u16 vdd1_on;
 	u16 vdd1_onlp;
 	u16 vdd1_ret;
 	u16 vdd1_off;
+/* PRM_VC_CMD_VAL_1 specific bits */
+	u16 vdd2_on;
+	u16 vdd2_onlp;
+	u16 vdd2_ret;
+	u16 vdd2_off;
 };
 
 #define VOLTSCALE_VPFORCEUPDATE		1
-- 
1.7.0.4

Re: [PATCH v6 4/7] omap3: pm: changing vdd0_/vdd1_ to vdd1_/vdd2_ in VC param structure

[Kevin Hilman]

Lesly A M <leslyam@ti.com> writes:

> Rename vdd0_/vdd1_ to vdd1_/vdd2_ in VC param structure.

That answers "what?", but not "why?"

Yes, I know the answer right now, but I forget things often.  

Please help ease the pain of my forgetfullness by writing a
descriptive changelog so when I or anyone else looks at this in the
git history, they will be able to understand.

Kevin

RE: [PATCH v6 4/7] omap3: pm: changing vdd0_/vdd1_ to vdd1_/vdd2_ in VC param structure

[Lesly Arackal Manuel]

Hi Kevin,

> -----Original Message-----
> From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
> Sent: Thursday, June 03, 2010 11:15 PM
> To: Lesly A M
> Cc: linux-omap@vger.kernel.org; Lesly A M; Nishanth Menon; David Derrick;
> Samuel Ortiz
> Subject: Re: [PATCH v6 4/7] omap3: pm: changing vdd0_/vdd1_ to vdd1_/vdd2_
> in VC param structure
> 
> Lesly A M <leslyam@ti.com> writes:
> 
> > Rename vdd0_/vdd1_ to vdd1_/vdd2_ in VC param structure.
> 
> That answers "what?", but not "why?"
> 
> Yes, I know the answer right now, but I forget things often.
> 
> Please help ease the pain of my forgetfullness by writing a
> descriptive changelog so when I or anyone else looks at this in the
> git history, they will be able to understand.
> 
> Kevin

Actually there is no VDD0, its VDD1 & VDD2. So the renaming is done just to
avoid the confusion.

Regards,
Lesly A M

Re: [PATCH v6 4/7] omap3: pm: changing vdd0_/vdd1_ to vdd1_/vdd2_ in VC param structure

[Kevin Hilman]

"Lesly Arackal Manuel" <leslyam@ti.com> writes:

> Hi Kevin,
>
>> -----Original Message-----
>> From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
>> Sent: Thursday, June 03, 2010 11:15 PM
>> To: Lesly A M
>> Cc: linux-omap@vger.kernel.org; Lesly A M; Nishanth Menon; David Derrick;
>> Samuel Ortiz
>> Subject: Re: [PATCH v6 4/7] omap3: pm: changing vdd0_/vdd1_ to vdd1_/vdd2_
>> in VC param structure
>> 
>> Lesly A M <leslyam@ti.com> writes:
>> 
>> > Rename vdd0_/vdd1_ to vdd1_/vdd2_ in VC param structure.
>> 
>> That answers "what?", but not "why?"
>> 
>> Yes, I know the answer right now, but I forget things often.
>> 
>> Please help ease the pain of my forgetfullness by writing a
>> descriptive changelog so when I or anyone else looks at this in the
>> git history, they will be able to understand.
>> 
>> Kevin
>
> Actually there is no VDD0, its VDD1 & VDD2. So the renaming is done just to
> avoid the confusion.

Yes.  As I said above, I do know why.  I just want it to be in the
changelog so when I forget, it will be easy for me to remember why.

*In the changelog*, you should be stating that you are changing the
names to match the hardware documentation or something along those
lines.

Kevin