From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Madhusudhan" Subject: RE: [PATCH v3] OMAP: Fix for bus width which improves SD card's peformance. Date: Mon, 5 Apr 2010 12:19:29 -0500 Message-ID: <007c01cad4e4$26c5a700$544ff780@am.dhcp.ti.com> References: <35697.192.168.10.89.1265898023.squirrel@dbdmail.itg.ti.com> <004701caab40$68b576e0$544ff780@am.dhcp.ti.com> <003b01cad0f0$6ea78040$544ff780@am.dhcp.ti.com> <003c01cad1b1$da2cdbf0$544ff780@am.dhcp.ti.com> <20100405164839.GB17388@gandalf> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from comal.ext.ti.com ([198.47.26.152]:51117 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755213Ab0DERTq (ORCPT ); Mon, 5 Apr 2010 13:19:46 -0400 In-Reply-To: <20100405164839.GB17388@gandalf> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: me@felipebalbi.com, 'kishore kadiyala' Cc: 'Vimal Singh' , tony@atomide.com, svenkatr@ti.com, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, jarkko.lavinen@nokia.com > -----Original Message----- > From: Felipe Balbi [mailto:me@felipebalbi.com] > Sent: Monday, April 05, 2010 11:49 AM > To: kishore kadiyala > Cc: Madhusudhan; Vimal Singh; tony@atomide.com; svenkatr@ti.com; linux- > omap@vger.kernel.org; linux-kernel@vger.kernel.org; > jarkko.lavinen@nokia.com > Subject: Re: [PATCH v3] OMAP: Fix for bus width which improves SD card's > peformance. > > Hi, > > On Mon, Apr 05, 2010 at 06:26:16PM +0530, kishore kadiyala wrote: > > @@ -2091,9 +2091,9 @@ static int __init omap_hsmmc_probe(struct > > mmc->caps |= MMC_CAP_MMC_HIGHSPEED | MMC_CAP_SD_HIGHSPEED | > > MMC_CAP_WAIT_WHILE_BUSY; > > > > - if (mmc_slot(host).wires >= 8) > > - mmc->caps |= MMC_CAP_8_BIT_DATA; > > - else if (mmc_slot(host).wires >= 4) > > + if (mmc_slot(host).wires == 8) > > + mmc->caps |= (MMC_CAP_8_BIT_DATA | MMC_CAP_4_BIT_DATA); > > + else if (mmc_slot(host).wires == 4) > > mmc->caps |= MMC_CAP_4_BIT_DATA; > > I believe it would be enough to just remove the 'else', so the code > would look like: > > if (mmc_slot(host).wires >= 8) > mmc->caps |= MMC_CAP_8_BIT_DATA; > if (mmc_slot(host).wires >= 4) Since the first if command already checks for the 8-bit the second check like >= 4 is definitely not readable in my opinion. Functionally do you see anything wrong with this patch?? > mmc->caps |= MMC_CAP_4_BIT_DATA; > > -- > balbi