Re: [PATCH]Add 3430 SDP board level support for HSMMC2

["Madhusudhan Chikkature" <madhu.cr@ti.com>]

----- Original Message ----- 
From: "Tony Lindgren" <tony@atomide.com>
To: "David Brownell" <david-b@pacbell.net>
Cc: "Madhusudhan Chikkature" <madhu.cr@ti.com>; <linux-omap@vger.kernel.org>
Sent: Thursday, September 11, 2008 5:29 AM
Subject: Re: [PATCH]Add 3430 SDP board level support for HSMMC2


>* David Brownell <david-b@pacbell.net> [080908 12:26]:
>> On Wednesday 13 August 2008, Madhusudhan Chikkature wrote:
>> > > A better way to do this would be to let the boards say exactly
>> > > what the hardware configuration is, rather than requiring all
>> > > OMAP3 boards to be set up exactly like the SDP...
>> >
>> > I think the initial version was written specific to SDP. Later
>> > on it was changed to hsmmc.c and the platforms which required
>> > simillar setup as SDP started using it.
>> 
>> Right ...
>> 
>> 
>> > Now, if support for a new board is required which is unlike SDP a  
>> > new file can still be added for that perticular board, right?
>> 
>> Each board already gets a board-XYZ.c file.  So the clean way
>> to do this is to have that file set up its hsmmc config ... NOT
>> to clone versions of hsmmc.c for each board!
> 
> Madhu, are you planning to abstract hsmmc.c further so various boards
> can use it?
Tony, Sorry for the delayed response on this. What level of abstraction are we considering here?
Are we looking at abstracting out the power stuff (T2 LDO stuff) like the way H4 MMC board file uses
menelaus driver? What is expected?

Regards,
Madhu
> 
> Tony
> 
>