* [Resending - PATCH 1/3] Triton BCI driver device setup for OMAP3430
@ 2008-07-03 12:05 Madhusudhan Chikkature
2008-07-03 13:08 ` Felipe Balbi
0 siblings, 1 reply; 5+ messages in thread
From: Madhusudhan Chikkature @ 2008-07-03 12:05 UTC (permalink / raw)
To: tony; +Cc: linux-omap, me
Hi Tony,
I am resending the BCI patch series after fixing the comments provided by Filipe.
Regards,
Madhu
-------------------------------------------------------------------------
From: Madhusudhan Chikkature<madhu.cr@ti.com>
Device setup/initialization for the Triton battery charger interface driver for
the OMAP3430 SDP.
Signed-off-by: Madhusudhan Chikkature<madhu.cr@ti.com>
---
arch/arm/mach-omap2/Makefile | 3 +-
arch/arm/mach-omap2/bci.c | 34 ++++++++++++++++++++++++++++++
arch/arm/mach-omap2/board-3430sdp.c | 1
include/asm-arm/arch-omap/board-3430sdp.h | 1
4 files changed, 38 insertions(+), 1 deletion(-)
Index: linux-omap-2.6/arch/arm/mach-omap2/Makefile
===================================================================
--- linux-omap-2.6.orig/arch/arm/mach-omap2/Makefile 2008-07-03
16:58:02.000000000 +0530
+++ linux-omap-2.6/arch/arm/mach-omap2/Makefile 2008-07-03 16:58:30.000000000
+0530
@@ -47,7 +47,8 @@ obj-$(CONFIG_MACH_OMAP_3430SDP) += boar
hsmmc.o \
usb-musb.o \
usb-ehci.o \
- board-3430sdp-flash.o
+ board-3430sdp-flash.o \
+ bci.o
obj-$(CONFIG_MACH_OMAP3EVM) += board-omap3evm.o \
hsmmc.o \
usb-musb.o usb-ehci.o \
Index: linux-omap-2.6/arch/arm/mach-omap2/board-3430sdp.c
===================================================================
--- linux-omap-2.6.orig/arch/arm/mach-omap2/board-3430sdp.c 2008-07-03
16:58:02.000000000 +0530
+++ linux-omap-2.6/arch/arm/mach-omap2/board-3430sdp.c 2008-07-03
16:58:30.000000000 +0530
@@ -299,6 +299,7 @@ static void __init omap_3430sdp_init(voi
ARRAY_SIZE(sdp3430_spi_board_info));
ads7846_dev_init();
sdp3430_flash_init();
+ twl4030_bci_battery_init();
omap_serial_init();
usb_musb_init();
usb_ehci_init();
Index: linux-omap-2.6/include/asm-arm/arch-omap/board-3430sdp.h
===================================================================
--- linux-omap-2.6.orig/include/asm-arm/arch-omap/board-3430sdp.h 2008-07-03
16:58:02.000000000 +0530
+++ linux-omap-2.6/include/asm-arm/arch-omap/board-3430sdp.h 2008-07-03
16:58:30.000000000 +0530
@@ -31,6 +31,7 @@
extern void sdp3430_usb_init(void);
extern void sdp3430_flash_init(void);
+extern void twl4030_bci_battery_init(void);
#define DEBUG_BASE 0x08000000 /* debug board */
Index: linux-omap-2.6/arch/arm/mach-omap2/bci.c
===================================================================
--- /dev/null 1970-01-01 00:00:00.000000000 +0000
+++ linux-omap-2.6/arch/arm/mach-omap2/bci.c 2008-07-03 16:59:40.000000000 +0530
@@ -0,0 +1,34 @@
+/*
+ * linux/arch/arm/mach-omap2/board-3430sdp-bci.c
+ *
+ * TWL4030 BCI platform device setup/initialization
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ */
+
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/platform_device.h>
+
+#if defined(CONFIG_TWL4030_BCI_BATTERY) || \
+ defined(CONFIG_TWL4030_BCI_BATTERY_MODULE)
+
+static struct platform_device twl4030_bci_battery_device = {
+ .name = "twl4030-bci-battery",
+ .id = 1,
+ .num_resources = 0,
+};
+
+void __init twl4030_bci_battery_init(void)
+{
+ (void) platform_device_register(&twl4030_bci_battery_device);
+}
+#else
+void __init twl4030_bci_battery_init(void)
+{
+}
+#endif
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Resending - PATCH 1/3] Triton BCI driver device setup for OMAP3430
2008-07-03 12:05 [Resending - PATCH 1/3] Triton BCI driver device setup for OMAP3430 Madhusudhan Chikkature
@ 2008-07-03 13:08 ` Felipe Balbi
2008-07-03 13:53 ` Madhusudhan Chikkature
0 siblings, 1 reply; 5+ messages in thread
From: Felipe Balbi @ 2008-07-03 13:08 UTC (permalink / raw)
To: Madhusudhan Chikkature; +Cc: tony, linux-omap
On Thu, 3 Jul 2008 17:35:50 +0530 (IST), "Madhusudhan Chikkature"
<madhu.cr@ti.com> wrote:
> Index: linux-omap-2.6/arch/arm/mach-omap2/bci.c
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ linux-omap-2.6/arch/arm/mach-omap2/bci.c 2008-07-03
16:59:40.000000000
> +0530
> @@ -0,0 +1,34 @@
> +/*
> + * linux/arch/arm/mach-omap2/board-3430sdp-bci.c
just fix this name please.
Style only.
> +
> +static struct platform_device twl4030_bci_battery_device = {
> + .name = "twl4030-bci-battery",
> + .id = 1,
use -1. There will be no other twl4030-bci-battery in the system :-)
--
Best Regards,
Felipe Balbi
http://blog.felipebalbi.com
me@felipebalbi.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Resending - PATCH 1/3] Triton BCI driver device setup for OMAP3430
2008-07-03 13:08 ` Felipe Balbi
@ 2008-07-03 13:53 ` Madhusudhan Chikkature
2008-07-03 14:07 ` Felipe Balbi
0 siblings, 1 reply; 5+ messages in thread
From: Madhusudhan Chikkature @ 2008-07-03 13:53 UTC (permalink / raw)
To: Felipe Balbi; +Cc: tony, linux-omap
----- Original Message -----
From: "Felipe Balbi" <me@felipebalbi.com>
To: "Madhusudhan Chikkature" <madhu.cr@ti.com>
Cc: <tony@atomide.com>; <linux-omap@vger.kernel.org>
Sent: Thursday, July 03, 2008 6:38 PM
Subject: Re: [Resending - PATCH 1/3] Triton BCI driver device setup for OMAP3430
>
>
> On Thu, 3 Jul 2008 17:35:50 +0530 (IST), "Madhusudhan Chikkature"
> <madhu.cr@ti.com> wrote:
>
>> Index: linux-omap-2.6/arch/arm/mach-omap2/bci.c
>> ===================================================================
>> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
>> +++ linux-omap-2.6/arch/arm/mach-omap2/bci.c 2008-07-03
> 16:59:40.000000000
>> +0530
>> @@ -0,0 +1,34 @@
>> +/*
>> + * linux/arch/arm/mach-omap2/board-3430sdp-bci.c
>
> just fix this name please.
Okay. I missed this one. I will correct it.
>
> Style only.
What does this mean?
>
>
>> +
>> +static struct platform_device twl4030_bci_battery_device = {
>> + .name = "twl4030-bci-battery",
>> + .id = 1,
>
> use -1. There will be no other twl4030-bci-battery in the system :-)
>
> --
> Best Regards,
>
> Felipe Balbi
> http://blog.felipebalbi.com
> me@felipebalbi.com
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Resending - PATCH 1/3] Triton BCI driver device setup for OMAP3430
2008-07-03 13:53 ` Madhusudhan Chikkature
@ 2008-07-03 14:07 ` Felipe Balbi
0 siblings, 0 replies; 5+ messages in thread
From: Felipe Balbi @ 2008-07-03 14:07 UTC (permalink / raw)
To: Madhusudhan Chikkature; +Cc: tony, linux-omap
On Thu, 3 Jul 2008 19:23:51 +0530, "Madhusudhan Chikkature"
<madhu.cr@ti.com> wrote:
>> Style only.
> What does this mean?
not code related, style comment :-p
--
Best Regards,
Felipe Balbi
http://blog.felipebalbi.com
me@felipebalbi.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Resending - PATCH 1/3] Triton BCI driver device setup for OMAP3430
@ 2008-07-04 4:36 Madhusudhan Chikkature
0 siblings, 0 replies; 5+ messages in thread
From: Madhusudhan Chikkature @ 2008-07-04 4:36 UTC (permalink / raw)
To: tony; +Cc: linux-omap, me
Hi Tony,
I fixed couple of minor comments from Filipe.
Regards,
Madhu
----------------------------------------------------------------
From: Madhusudhan Chikkature<madhu.cr@ti.com>
Device setup/initialization for the Triton battery charger interface driver for
the OMAP3430 SDP.
Signed-off-by: Madhusudhan Chikkature<madhu.cr@ti.com>
---
arch/arm/mach-omap2/Makefile | 3 +-
arch/arm/mach-omap2/bci.c | 34 ++++++++++++++++++++++++++++++
arch/arm/mach-omap2/board-3430sdp.c | 1
include/asm-arm/arch-omap/board-3430sdp.h | 1
4 files changed, 38 insertions(+), 1 deletion(-)
Index: linux-omap-2.6/arch/arm/mach-omap2/Makefile
===================================================================
--- linux-omap-2.6.orig/arch/arm/mach-omap2/Makefile 2008-07-03
16:58:02.000000000 +0530
+++ linux-omap-2.6/arch/arm/mach-omap2/Makefile 2008-07-03 16:58:30.000000000
+0530
@@ -47,7 +47,8 @@ obj-$(CONFIG_MACH_OMAP_3430SDP) += boar
hsmmc.o \
usb-musb.o \
usb-ehci.o \
- board-3430sdp-flash.o
+ board-3430sdp-flash.o \
+ bci.o
obj-$(CONFIG_MACH_OMAP3EVM) += board-omap3evm.o \
hsmmc.o \
usb-musb.o usb-ehci.o \
Index: linux-omap-2.6/arch/arm/mach-omap2/board-3430sdp.c
===================================================================
--- linux-omap-2.6.orig/arch/arm/mach-omap2/board-3430sdp.c 2008-07-03
16:58:02.000000000 +0530
+++ linux-omap-2.6/arch/arm/mach-omap2/board-3430sdp.c 2008-07-03
16:58:30.000000000 +0530
@@ -299,6 +299,7 @@ static void __init omap_3430sdp_init(voi
ARRAY_SIZE(sdp3430_spi_board_info));
ads7846_dev_init();
sdp3430_flash_init();
+ twl4030_bci_battery_init();
omap_serial_init();
usb_musb_init();
usb_ehci_init();
Index: linux-omap-2.6/include/asm-arm/arch-omap/board-3430sdp.h
===================================================================
--- linux-omap-2.6.orig/include/asm-arm/arch-omap/board-3430sdp.h 2008-07-03
16:58:02.000000000 +0530
+++ linux-omap-2.6/include/asm-arm/arch-omap/board-3430sdp.h 2008-07-03
16:58:30.000000000 +0530
@@ -31,6 +31,7 @@
extern void sdp3430_usb_init(void);
extern void sdp3430_flash_init(void);
+extern void twl4030_bci_battery_init(void);
#define DEBUG_BASE 0x08000000 /* debug board */
Index: linux-omap-2.6/arch/arm/mach-omap2/bci.c
===================================================================
--- /dev/null 1970-01-01 00:00:00.000000000 +0000
+++ linux-omap-2.6/arch/arm/mach-omap2/bci.c 2008-07-03 19:40:37.000000000 +0530
@@ -0,0 +1,34 @@
+/*
+ * linux/arch/arm/mach-omap2/bci.c
+ *
+ * TWL4030 BCI platform device setup/initialization
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ */
+
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/platform_device.h>
+
+#if defined(CONFIG_TWL4030_BCI_BATTERY) || \
+ defined(CONFIG_TWL4030_BCI_BATTERY_MODULE)
+
+static struct platform_device twl4030_bci_battery_device = {
+ .name = "twl4030-bci-battery",
+ .id = -1,
+ .num_resources = 0,
+};
+
+void __init twl4030_bci_battery_init(void)
+{
+ (void) platform_device_register(&twl4030_bci_battery_device);
+}
+#else
+void __init twl4030_bci_battery_init(void)
+{
+}
+#endif
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-07-04 4:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-03 12:05 [Resending - PATCH 1/3] Triton BCI driver device setup for OMAP3430 Madhusudhan Chikkature
2008-07-03 13:08 ` Felipe Balbi
2008-07-03 13:53 ` Madhusudhan Chikkature
2008-07-03 14:07 ` Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2008-07-04 4:36 Madhusudhan Chikkature
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox