public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: "Girish" <girishsg@ti.com>
To: 'Daniel Stone' <daniel.stone@nokia.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: RE: [PATC 2/3]  silicon revision check for OMAP2/3
Date: Mon, 5 Nov 2007 17:29:47 +0530	[thread overview]
Message-ID: <012101c81fa3$5d253930$6a8918ac@ent.ti.com> (raw)
In-Reply-To: <20071102155706.GA24982@intune.research.nokia.com>


>> +get_device_type() \
>> +		((system_rev & 0x700) >> 8)
>
>Nice work on defining the get_device_type() macro, but why not 
>use it above, so you have:
>#define is_device_type_test() (get_device_type == DEVICE_TYPE_TEST)

Thanks, all your comments have been incorporated.

Regards,
girish

      reply	other threads:[~2007-11-05 11:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-02 14:43 [PATC 2/3] silicon revision check for OMAP2/3 Girish
2007-11-02 15:57 ` Daniel Stone
2007-11-05 11:59   ` Girish [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='012101c81fa3$5d253930$6a8918ac@ent.ti.com' \
    --to=girishsg@ti.com \
    --cc=daniel.stone@nokia.com \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox