From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hemanth V" Subject: Re: [PATCH V2] misc : ROHM BH1780GLI Ambient light sensor Driver Date: Wed, 2 Jun 2010 14:29:45 +0530 Message-ID: <014201cb0231$f68119a0$LocalHost@wipblrx0099946> References: <39216.10.24.255.17.1274699065.squirrel@dbdmail.itg.ti.com><20100601131244.7164b43c.akpm@linux-foundation.org><4C056FEE.3040107@jic23.retrosnub.co.uk> <20100601135430.9c8c28df.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit Return-path: Sender: linux-kernel-owner@vger.kernel.org To: Andrew Morton , Jonathan Cameron Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Daniel Mack , Jonathan Cameron , Wolfram Sang List-Id: linux-omap@vger.kernel.org ----- Original Message ----- From: "Andrew Morton" To: "Jonathan Cameron" Cc: "Hemanth V" ; ; ; "Daniel Mack" ; "Jonathan Cameron" ; "Wolfram Sang" Sent: Wednesday, June 02, 2010 2:24 AM Subject: Re: [PATCH V2] misc : ROHM BH1780GLI Ambient light sensor Driver > On Tue, 01 Jun 2010 21:39:10 +0100 > Jonathan Cameron wrote: > >> > >> > It would be most useful if the changelog were to fully describe the >> > proposed kernel<->userspace interface. That's the most important part >> > of the driver, because it's the only part we can never change. >> > >> > There is a desultory effort to maintain sysfs API descriptions under >> > Documentation/ABI/. I'd have thought that it would be appropriate to >> > document this driver's ABI in there. >> Agreed, but we get back to the debate of what we should standardise on. > > I'd suggest standardising on one of the existing drivers. That way we > have two compliant drivers and only need to change (n-2) others. If we > pick some new standard then we need to change (n) drivers. > Currently this driver follows the same sysfs convention as supported by isl29003.c in drivers/misc.