From: "Rajendra Nayak" <rnayak@ti.com>
To: 'Kevin Hilman' <khilman@deeprootsystems.com>
Cc: linux-omap@vger.kernel.org
Subject: RE: [PATCH 07/12] System Control Module context save/restore
Date: Thu, 11 Sep 2008 12:22:27 +0530 [thread overview]
Message-ID: <016301c913da$f568bc90$LocalHost@wipultra1382> (raw)
In-Reply-To: <48C8ADC7.9020109@deeprootsystems.com>
> >>> #define OMAP3430_PRM_RSTST \
> >>> OMAP34XX_PRM_REGADDR(OMAP3430_GR_MOD, RM_RSTST)
> >>> +static struct omap3_control_module_regs control_ctx;
> >>> +
> >> I'm not sure what this patch was generated against, but it doesn't
> >> apply against linux-omap. The PRM_RSTST definition above is not in
> >> linux-omap code.
> >>
> >> Kevin
> >
> > There is no reference to PRM_RSTST in this patch. It uses
> RM_RSTST which
> > can be found in arch/arm/mach-omap2/prm.h.
>
> You can see in the above quoted text that your 7/12 patch
> adds some code
> immediately after a line which defines OMAP3430_PRM_RSTST.
> Since this
> existing code is not in linux-omap, and I couldn't find it in
> previous
> patches, it's not clear what this patch was generated against.
>
> Kevin
Yes, those lines are not present in linux-omap and are added by patch [PATCH 03/06] scratchpad populate
posted by me on 08/26/2008. It is part of the patch set [PATCH 00/06] OMAP3 CPUidle patches - supports C0-C5
posted the same day.
To summarise I have posted 2 patch sets as discussed earlier for CPUIdle
1) [PATCH 00/06] OMAP3 CPUidle patches - supports C0-C5 - posted on 08/26/2008
2) [PATCH 00/12] OMAP3 CPUidle context save/restore patches - supports C6 - posted on 09/01/2008
Apart from these the following patch set posted by Jouni is needed for these patches to apply
1) [PATCH 0/4] Refreshed PM workaround patches 2. - posted on 07/15/2008
NOTE: Patch 1/4 from this set is already pushed in l-o mainline.
So if you apply the patches in the following order on top of commit 81c893795c2e1fbe0bf5f638e.. I am
hoping they should work.
1) [PATCH 0/4] Refreshed PM workaround patches 2.
2) [PATCH 00/06] OMAP3 CPUidle patches - supports C0-C5
3) [PATCH 00/12] OMAP3 CPUidle context save/restore patches
next prev parent reply other threads:[~2008-09-11 6:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 13:40 [PATCH 07/12] System Control Module context save/restore Rajendra Nayak
2008-09-04 9:15 ` Kevin Hilman
2008-09-10 14:47 ` Kevin Hilman
2008-09-11 5:01 ` Rajendra Nayak
2008-09-11 5:33 ` Kevin Hilman
2008-09-11 6:52 ` Rajendra Nayak [this message]
2008-09-11 7:32 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='016301c913da$f568bc90$LocalHost@wipultra1382' \
--to=rnayak@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox