From: "Maulik" <x0082077@ti.com>
To: me@felipebalbi.com
Cc: linux-omap@vger.kernel.org, linux-usb@vger.kernel.org,
'Tony Lindgren' <tony@atomide.com>,
'Felipe Balbi' <felipe.balbi@nokia.com>,
'Greg Kroah-Hartman' <gregkh@suse.de>,
'Olof Johansson' <olof@lixom.net>,
'Sergei Shtylyov' <sshtylyov@ru.mvista.com>,
"'Gupta, Ajay Kumar'" <ajay.gupta@ti.com>
Subject: RE: [PATCH v2 1/2] ARM : OMAP : Add empty functions in header file
Date: Mon, 4 Jan 2010 18:18:08 +0530 [thread overview]
Message-ID: <016301ca8d3c$2d2b7f60$808918ac@apr.dhcp.ti.com> (raw)
In-Reply-To: <20100104123423.GA1439@gandalf>
>>not omap-specific. How about USB: instead ?
[Maulik] Yes this can go through linux-usb.
> +#if defined(CONFIG_USB_NOP_XCEIV)
> /* sometimes transceivers are accessed only through e.g. ULPI */
> extern void usb_nop_xceiv_register(void);
> extern void usb_nop_xceiv_unregister(void);
> +#else
> +extern inline void usb_nop_xceiv_register()
> +{
> +}
> +
> +extern inline void usb_nop_xceiv_unregister()
>>I hope these are copy&paste error
[Maulik] Nope. When 'extern' is dropped I get the following error while
compiling when CONFIG_USB_NOP_XCEIV is NOT defined.
arch/arm/plat-omap/built-in.o: In function `usb_nop_xceiv_unregister':
/share/maulik/felipe_musb/include/linux/usb/otg.h:123: multiple definition
of `usb_nop_xceiv_unregister'
arch/arm/mach-omap2/built-in.o:/share/maulik/felipe_musb/include/linux/usb/o
tg.h:123: first defined here
arch/arm/plat-omap/built-in.o: In function `usb_nop_xceiv_register':
/share/maulik/felipe_musb/include/linux/usb/otg.h:119: multiple definition
of `usb_nop_xceiv_register'
arch/arm/mach-omap2/built-in.o:/share/maulik/felipe_musb/include/linux/usb/o
tg.h:119: first defined here
make: *** [vmlinux.o] Error 1
I referred some kernel code which uses extern inline.
Any suggestions?
Regards,
Maulik
next prev parent reply other threads:[~2010-01-04 12:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-04 11:09 [PATCH v2 1/2] ARM : OMAP : Add empty functions in header file Maulik Mankad
[not found] ` <1262603399-13036-1-git-send-email-x0082077-l0cyMroinI0@public.gmane.org>
2010-01-04 12:29 ` Gupta, Ajay Kumar
2010-01-04 12:34 ` Felipe Balbi
2010-01-04 12:48 ` Maulik [this message]
[not found] ` <016301ca8d3c$2d2b7f60$808918ac-wD+IZp/g4/2mHdYHvhjUOg@public.gmane.org>
2010-01-04 15:25 ` Olof Johansson
2010-01-05 5:15 ` Maulik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='016301ca8d3c$2d2b7f60$808918ac@apr.dhcp.ti.com' \
--to=x0082077@ti.com \
--cc=ajay.gupta@ti.com \
--cc=felipe.balbi@nokia.com \
--cc=gregkh@suse.de \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=me@felipebalbi.com \
--cc=olof@lixom.net \
--cc=sshtylyov@ru.mvista.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox