From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Madhusudhan Chikkature" Subject: Re: [PATCH 7/9]HDQ driver:replace semaphore with mutex Date: Wed, 24 Sep 2008 18:30:22 +0530 Message-ID: <020a01c91e45$838ecb80$LocalHost@wipultra1303> References: <56530.192.168.10.89.1222255887.squirrel@dbdmail.itg.ti.com> <20080924115031.GO24627@gandalf.research.nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:59139 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751318AbYIXNAs convert rfc822-to-8bit (ORCPT ); Wed, 24 Sep 2008 09:00:48 -0400 Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org Cc: tony@atomide.com, johnpol@2ka.mipt.ru, felipe.balbi@nokia.com, linux-omap@vger.kernel.org ----- Original Message ----- From: "Felipe Balbi" To: "ext Madhusudhan Chikkature" Cc: ; ; ; Sent: Wednesday, September 24, 2008 5:20 PM Subject: Re: [PATCH 7/9]HDQ driver:replace semaphore with mutex > On Wed, Sep 24, 2008 at 05:01:27PM +0530, ext Madhusudhan Chikkature wrote: >> From: Madhusudhan Chikkature >> >> This patch replaces the usage of semaphore by mutex. >> >> Signed-off-by: Madhusudhan Chikkature >> --- >> drivers/w1/masters/omap_hdq.c | 42 ++++++++++++++++++++++-------------------- >> 1 files changed, 22 insertions(+), 20 deletions(-) >> >> Index: linux-omap-2.6/drivers/w1/masters/omap_hdq.c >> =================================================================== >> --- linux-omap-2.6.orig/drivers/w1/masters/omap_hdq.c 2008-09-24 >> 11:13:12.000000000 +0530 >> +++ linux-omap-2.6/drivers/w1/masters/omap_hdq.c 2008-09-24 11:49:45.000000000 >> +0530 >> @@ -55,7 +55,7 @@ static int w1_id; >> struct hdq_data { >> struct device *dev; >> void __iomem *hdq_base; >> - struct semaphore hdq_semlock; >> + struct mutex hdq_mutex; >> int hdq_usecount; >> struct clk *hdq_ick; >> struct clk *hdq_fck; > > Please, fix these two: > > CHECK: struct mutex definition without comment > #58: FILE: w1/masters/omap_hdq.c:58: > + struct mutex hdq_mutex; > > CHECK: spinlock_t definition without comment > #63: FILE: w1/masters/omap_hdq.c:63: > + spinlock_t hdq_spinlock; > > total: 0 errors, 0 warnings, 2 checks, 732 lines checked I dont see any such checks reported by checkpatch.pl? Regards, Madhu > > -- > balbi > >