Re: [PATCH 7/9]HDQ driver:replace semaphore with mutex

["Madhusudhan Chikkature" <madhu.cr@ti.com>]

----- Original Message ----- 
From: "Gadiyar, Anand" <gadiyar@ti.com>
To: "Chikkature Rajashekar, Madhusudhan" <madhu.cr@ti.com>; <felipe.balbi@nokia.com>
Cc: <tony@atomide.com>; <johnpol@2ka.mipt.ru>; <felipe.balbi@nokia.com>; <linux-omap@vger.kernel.org>
Sent: Wednesday, September 24, 2008 6:35 PM
Subject: RE: [PATCH 7/9]HDQ driver:replace semaphore with mutex


> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org On Behalf Of Chikkature Rajashekar, Madhusudhan
> ----- Original Message ----- From: "Felipe Balbi" <felipe.balbi@nokia.com>
> 
> > On Wed, Sep 24, 2008 at 05:01:27PM +0530, ext Madhusudhan Chikkature wrote:
> >> From: Madhusudhan Chikkature<madhu.cr@ti.com>
> >> 
> >> This patch replaces the usage of semaphore by mutex.
> >> 
> >> Signed-off-by: Madhusudhan Chikkature<madhu.cr@ti.com>
> >> ---
> >>  drivers/w1/masters/omap_hdq.c |   42 ++++++++++++++++++++++--------------------
> >>  1 files changed, 22 insertions(+), 20 deletions(-)
> >> 
> >> Index: linux-omap-2.6/drivers/w1/masters/omap_hdq.c
> >> ===================================================================
> >> --- linux-omap-2.6.orig/drivers/w1/masters/omap_hdq.c 2008-09-24 11:13:12.000000000 +0530
> >> +++ linux-omap-2.6/drivers/w1/masters/omap_hdq.c 2008-09-24 11:49:45.000000000 +0530
> >> @@ -55,7 +55,7 @@ static int w1_id;
> >>  struct hdq_data {
> >>  struct device *dev;
> >>  void __iomem *hdq_base;
> >> - struct semaphore hdq_semlock;
> >> + struct  mutex hdq_mutex;
> >>  int hdq_usecount;
> >>  struct clk *hdq_ick;
> >>  struct clk *hdq_fck;
> > 
> > Please, fix these two:
> > 
> > CHECK: struct  mutex definition without comment
> > #58: FILE: w1/masters/omap_hdq.c:58:
> > + struct  mutex hdq_mutex;
> > 
> > CHECK: spinlock_t definition without comment
> > #63: FILE: w1/masters/omap_hdq.c:63:
> > + spinlock_t hdq_spinlock;
> > 
> > total: 0 errors, 0 warnings, 2 checks, 732 lines checked
> 
> I dont see any such checks reported by checkpatch.pl?
> 

Oh, I guess Felipe uses `checkpatch.pl --strict`, right Felipe?

Hi,
Yes. That seems to be the case. I will add a couple of simple comments. I will send a final patch (patch #10)which will fix these minor things which Filipe reported.I do not want to rebase any of my patches again :)

Regards,
Madhu

- Anand