RE: [PATCH 04/09] OMAP PM srf implementation

["Rajendra Nayak" <rnayak@ti.com>]

Hi Peter,
 
> -----Original Message-----
> From: Peter 'p2' De Schrijver [mailto:peter.de-schrijver@nokia.com] 
> Sent: Monday, July 14, 2008 6:59 PM
> To: ext Rajendra Nayak
> Cc: linux-omap@vger.kernel.org
> Subject: Re: [PATCH 04/09] OMAP PM srf implementation
> 
> Hi Rajendra,
> 
> > +void omap_pm_set_min_bus_tput(struct device *dev, struct 
> bus_type *bus,
> > +				    unsigned long r)
> 
> According to Paul's prototypes this should be 
> void omap_pm_set_min_bus_tput(struct device *dev, u8 agent_id, 
> 			      unsigned long r)
> 				
> > +{
> > +	if (!dev) {
> > +		WARN_ON(1);
> > +		return;
> > +	};
> > +
> > +	if (r == 0)
> > +		pr_debug("OMAP PM: remove min bus tput constraint: "
> > +			 "dev %p for bus %s\n", dev, bus->name);
> > +	else
> > +		pr_debug("OMAP PM: add min bus tput constraint: "
> > +			 "dev %p for bus %s: rate %ld KiB\n", dev,
> > +			 bus->name, r);
> > +
> > +	/*
> > +	 * This code should model the bus and compute the required
> > +	 * bus frequency, convert that to a VDD2 OPP ID, then 
> set the VDD2
> > +	 * OPP appropriately.
> > +	 *
> > +	 * TI CDP code can call constraint_set here on the VDD2 OPP.
> > +	 */
> > +}
> > +
> 
> omap_pm_if_early_init and omap_pm_if_init are missing. I added dummy
> functions for those.
> 
> With all of these changes it seems to work.

Yes, I probably was using an older omap-pm-noop patch from Paul. 
I did not refresh it since, the later one sent was again not the final one.
I though I would refresh it once the final version is posted.

Paul,
Would you be posting another version of this with changes as suggested 
by Jouni? 

> 
> Cheers,
> 
> Peter.
> 
> -- 
> goa is a state of mind
>