From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tanya Brokhman" Subject: RE: [PATCH] usb:gadget: use min_t() macro instead of min() Date: Mon, 13 Jun 2011 21:07:52 +0300 Message-ID: <03db01cc29f4$d472bcb0$7d583610$@org> References: <03b901cc29c0$6538e970$2faabc50$@org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-us Sender: linux-arm-msm-owner@vger.kernel.org To: 'Alan Stern' Cc: balbi@ti.com, greg@kroah.com, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, ablay@codeaurora.org, 'open list' , "'open list:FREESCALE USB PER...'" , "'open list:OMAP USB SUPPORT'" List-Id: linux-omap@vger.kernel.org > > The change I suggested involved replacing two typecasts with a single > min_t. All (or almost all) the places this patch touches currently > contain only one typecast, so the motivation for changing them is a lot > weaker. > You're right. So what's the final call on this one? Do you think it can be merged or you prefer not change anything? I personally think the code looks nicer using min_t instead of min with casting but that's just my opinion and of course there are arguments against this patch. Thanks, Tanya Brokhman --- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.