From: Vishwanath Sripathy <vishwanath.bs@ti.com>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: linux-omap@vger.kernel.org, Paul Walmsely <paul@pwsan.com>
Subject: RE: [PATCH/RFC 2/2] OMAP: PM: implement context loss count APIs
Date: Sat, 11 Dec 2010 12:43:24 +0530 [thread overview]
Message-ID: <04a0c6e8413f897941850edcb93a176d@mail.gmail.com> (raw)
In-Reply-To: <87zksd5ebv.fsf@deeprootsystems.com>
Kevin,
> -----Original Message-----
> From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
> Sent: Saturday, December 11, 2010 6:14 AM
> To: Vishwanath Sripathy
> Cc: linux-omap@vger.kernel.org; Paul Walmsely
> Subject: Re: [PATCH/RFC 2/2] OMAP: PM: implement context loss count
> APIs
>
> Vishwanath Sripathy <vishwanath.bs@ti.com> writes:
>
> > Kevin,
> [...]
>
> >> @@ -288,20 +290,19 @@ unsigned long
> omap_pm_cpu_get_freq(void)
> >>
> >> int omap_pm_get_dev_context_loss_count(struct device *dev)
> >> {
> >> + struct platform_device *pdev = to_platform_device(dev);
> >> + int count;
> >> +
> >> if (!dev) {
> >> WARN_ON(1);
> >> return -EINVAL;
> >> };
> >>
> >> - pr_debug("OMAP PM: returning context loss count for dev %s\n",
> >> - dev_name(dev));
> >> + count = omap_device_get_context_loss_count(pdev);
> >> + pr_debug("OMAP PM: context loss count for dev %s = %d\n",
> >> + dev_name(dev), count);
> >
> > Shouldn't this implementation be part of omap-pm.c where all the
> OMAP PM
> > functions are to be implemented?
>
> Where is omap-pm.c?
It's not present and needs to be added. This file is anyway required for
adding device latency constraints as well.
Vishwa
>
> Kevin
next prev parent reply other threads:[~2010-12-11 7:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 0:08 [PATCH/RFC 1/2] OMAP2+: powerdomain: add API to get context loss count Kevin Hilman
2010-12-10 0:08 ` [PATCH/RFC 2/2] OMAP: PM: implement context loss count APIs Kevin Hilman
2010-12-10 11:28 ` Vishwanath Sripathy
2010-12-11 0:43 ` Kevin Hilman
2010-12-11 7:13 ` Vishwanath Sripathy [this message]
2010-12-13 10:43 ` Paul Walmsley
2010-12-13 13:48 ` Vishwanath Sripathy
2010-12-13 19:39 ` Paul Walmsley
2010-12-15 3:35 ` Paul Walmsley
2010-12-10 1:32 ` [PATCH/RFC 3/2] OMAP: PM noop: implement context loss count for non-omap_devices Kevin Hilman
2010-12-15 3:39 ` Paul Walmsley
2010-12-15 3:23 ` [PATCH/RFC 1/2] OMAP2+: powerdomain: add API to get context loss count Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04a0c6e8413f897941850edcb93a176d@mail.gmail.com \
--to=vishwanath.bs@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox