public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: "Madhusudhan Chikkature" <madhu.cr@ti.com>
To: Felipe Balbi <me@felipebalbi.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [RFC/PATCH 2/2] Triton Battery charger interface driver for OMAP3430
Date: Mon, 23 Jun 2008 19:05:12 +0530	[thread overview]
Message-ID: <04c501c8d535$f86fd240$35f6180a@ent.ti.com> (raw)
In-Reply-To: 27482475ea67b287e41df55112e188a9@felipebalbi.com

Hi Felipe,

Thanks for the comments. I will fix it and resend the patch.

Best regards,
Madhu
----- Original Message ----- 
From: "Felipe Balbi" <me@felipebalbi.com>
To: <x0070977@dbdmail.itg.ti.com>
Cc: <linux-omap@vger.kernel.org>
Sent: Monday, June 23, 2008 2:21 PM
Subject: Re: [RFC/PATCH 2/2] Triton Battery charger interface driver for OMAP3430


> 
> 
> On Fri, 20 Jun 2008 17:36:00 +0530 (IST), x0070977@dbdmail.itg.ti.com
> wrote:
> 
>> +#ifdef CONFIG_TWL4030_BCI_BATTERY
>> +extern int twl4030charger_usb_en(int enable);
>> +#else
>> +static inline int twl4030charger_usb_en(int enable) { return 0; }
>> +#endif
> 
> this should be in include/linux/i2c/twl4030.h
> you should also change it for when bci is built as a
> dynamically linked module.
Okay. Good point.
> 
> -- 
> Best Regards,
> 
> Felipe Balbi
> http://felipebalbi.com
> me@felipebalbi.com
> 
>

      reply	other threads:[~2008-06-23 13:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-20 12:06 [RFC/PATCH 2/2] Triton Battery charger interface driver for OMAP3430 x0070977
2008-06-23  8:51 ` Felipe Balbi
2008-06-23 13:35   ` Madhusudhan Chikkature [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='04c501c8d535$f86fd240$35f6180a@ent.ti.com' \
    --to=madhu.cr@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=me@felipebalbi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox