From: "shekhar, chandra" <x0044955@ti.com>
To: Jason Marini <jason.marini@gmail.com>, linux-omap@vger.kernel.org
Subject: Re: McBSP register question
Date: Mon, 15 Dec 2008 08:08:22 +0530 [thread overview]
Message-ID: <057c01c95e5e$33f76d80$LocalHost@wipultra806> (raw)
In-Reply-To: 423644ca0812121021k63a81930nb805b8ab7b5a6d84@mail.gmail.com
----- Original Message -----
From: "Jason Marini" <jason.marini@gmail.com>
To: <linux-omap@vger.kernel.org>
Sent: Friday, December 12, 2008 11:51 PM
Subject: McBSP register question
> Looking at the latest git head, I see that omap_mcbsp_pollwrite() and
> omap_mcbsp_pollread() improperly use readw() and writew() instead of
> OMAP_MCBSP_READ() and OMAP_MCBSP_WRITE() in the file
> arch/arm/plat-omap/mcbsp.c.
>
> But while I was editing this file, I also saw writes to
> OMAP_MCBSP_REG_DXR1, which is #define'd for ARCH_OMAP_34XX and
> ARCH_OMAP_24XX to be at an offset of 0x0C. The McBSP section of the
> TRM for the OMAP34xx has no mention of any registers existing at this
> offset.
>
> Why is this DXR1 and not just DXR?
It so happens that McBSP on 2420 has DXR1 and DXR2 registers, but not on
omap2430/34xx.
To provide multi-omap suport and avoid ifdefs dxr1/2 and drr1/2 has been
retained along with dxr and drr (same code mach-omap2/mcbsp.c supports 2420.) .
>
> -Jason Marini
> Associate Software Engineer
> Vocollect, Inc.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2008-12-15 2:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-12 18:21 McBSP register question Jason Marini
2008-12-15 2:38 ` shekhar, chandra [this message]
2008-12-15 15:38 ` Jason Marini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='057c01c95e5e$33f76d80$LocalHost@wipultra806' \
--to=x0044955@ti.com \
--cc=jason.marini@gmail.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox