Re: [PATCH 1/3] [OMAPZOOM] Lower i2c speed on bus 1 for LDP.

["shekhar, chandra" <x0044955@ti.com>]

----- Original Message ----- 
From: "Dominic Curran" <dcurran@ti.com>
To: <linux-omap@vger.kernel.org>
Sent: Thursday, November 13, 2008 1:51 AM
Subject: [PATCH 1/3] [OMAPZOOM] Lower i2c speed on bus 1 for LDP.


> Resending patch with more descriptive comment.
>
> Lower i2c bus 1 speed to 400KHz for LDP.
> At 2600KHz i2c reads from twl4030 keypad driver are returning
> incorrect data. Reason unknown. Lowering bus speed as temporary
> fix to get LDP keypad working.
>
> Signed-off-by: Dominic Curran <dcurran@ti.com>
> ---
> arch/arm/mach-omap2/board-ldp.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-ldp.c b/arch/arm/mach-omap2/board-ldp.c
> index d889ce8..b2e8c9c 100755
> --- a/arch/arm/mach-omap2/board-ldp.c
> +++ b/arch/arm/mach-omap2/board-ldp.c
> @@ -797,7 +797,7 @@ static struct i2c_board_info __initdata 
> ldp_i2c_boardinfo_2[] = {
>
> static int __init omap_i2c_init(void)
> {
> - omap_register_i2c_bus(1, 2600, ldp_i2c_boardinfo,
> + omap_register_i2c_bus(1, 400, ldp_i2c_boardinfo,
>  ARRAY_SIZE(ldp_i2c_boardinfo));


Last time i checked we were getting few errors (returning incorrect values) even 
at 400k , and no error at 100k.
Have you seen any at 400k?


>  omap_register_i2c_bus(2, 100, ldp_i2c_boardinfo_2,
>  ARRAY_SIZE(ldp_i2c_boardinfo_2));
> -- 
> 1.5.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>