From: Kyungmin Park <kyungmin.park@samsung.com>
To: linux-omap-open-source@linux.omap.com
Subject: [PATCH] 24xx dma patch
Date: Fri, 06 Jan 2006 16:33:06 +0900 [thread overview]
Message-ID: <0ISN000DPUB62T@mmp2.samsung.com> (raw)
Hi
It reads DMA status too early and use callback function.
It's make dma error on 24xx when playing the music.
Regards,
Kyungmin Park
--
diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
--- a/arch/arm/plat-omap/dma.c
+++ b/arch/arm/plat-omap/dma.c
@@ -866,8 +866,10 @@ static int omap2_dma_handle_ch(int ch)
val = 1 << (ch);
omap_writel(val, OMAP_DMA4_IRQSTATUS_L0);
- if (likely(dma_chan[ch].callback != NULL))
+ if (likely(dma_chan[ch].callback != NULL)) {
+ status = OMAP_DMA_CSR_REG(ch);
dma_chan[ch].callback(ch, status, dma_chan[ch].data);
+ }
return 0;
}
next reply other threads:[~2006-01-06 7:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-06 7:33 Kyungmin Park [this message]
2006-01-14 0:49 ` [PATCH] 24xx dma patch Tony Lindgren
[not found] <0ISN00BRPWM5ID@mmp1.samsung.com>
2006-01-10 10:52 ` Komal Shah
2006-01-11 4:59 ` Kyungmin Park
2006-01-14 1:02 ` Tony Lindgren
2006-01-14 1:04 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2006-01-11 5:12 Menon, Nishanth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ISN000DPUB62T@mmp2.samsung.com \
--to=kyungmin.park@samsung.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox