From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68C1C3EFD0A for ; Fri, 27 Mar 2026 13:19:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774617543; cv=none; b=gi7+AKA91NEvzDhj0YrHlFHRsSODaRC6E5ttfBpdDhZe22luQpNLV2OMAw0bAgkIIkwiac7pvZ5P4GO7KhnPeivx+JyNSU3XjrwOrkKDNM5Rgblo0sfcAYQBhKJ45DVIFqesO/KhlFFlV6FOmtA21FPNIhpjFEZnKnmJWE1aoak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774617543; c=relaxed/simple; bh=Ftlsz681zgqhKwKdw2wdE3UpwUeP9ZgfFK8yjps7MBs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lwzdfJ5Pdx4O7Lh8YckiMgCTwy0zhdmM8MCG190MSi4ojHibUo5Xdj7pzf03YT4e8Pecs9e7YnZYSjcBmVHXgIf9FuBF4JdYXxKZdkpTLZOqCh8PBnXK7v1iHNpl7DQzpf1QjiWHZrWpbiGDXW+5Xe5oLudWhfKDEWP7KbCvOEU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=TiblL0eN; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="TiblL0eN" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id C3DC71A3023; Fri, 27 Mar 2026 13:18:59 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 9434760230; Fri, 27 Mar 2026 13:18:59 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 3491D10451302; Fri, 27 Mar 2026 14:18:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1774617538; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=9cQUuQ/ZRSxD4m/Rh9Nc1u1MgzCT+v4F+G6fMpHiUlM=; b=TiblL0eNLCLJJ/15K7x2gdVr1DaLBZae6I/UTmpuGumSDGJ4KxzYCqEBprYwDQRftgx0f1 jMBCtp20A9UJhusrJM1fZSTR2Hx3yEQBTOuZJJPQDhlAaDNSlcngINbJ0tHcfCukuRNTdT p3QXOi39yprRBoIx0q7CCQqu3ZOTiR72sE6wshiNQ93x/o5qYtxmgR5XeQQ2pjqnmA2qXv cHxSrVIb+RsesR5FVCb0nrHCduFEN1guj7aXliO20RLPOw9g6jjQ3XrpNUvH/G5C49EylZ ZF/mCPfDvSFLRJNL0DSYxoX84hmQ40knUCO190wXl+PzybEGrJmZP6yYszbALA== Message-ID: <0e62fbaf-311b-458b-bf7d-63f20de28f44@bootlin.com> Date: Fri, 27 Mar 2026 14:18:53 +0100 Precedence: bulk X-Mailing-List: linux-omap@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/8] regulator: pbias: Add pbias SIM regulator for OMAP4 To: Andreas Kemnade Cc: Aaro Koskinen , Kevin Hilman , Roger Quadros , Tony Lindgren , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Thomas Petazzoni , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260323-omap4-fix-usb-support-v1-0-b668132124ac@bootlin.com> <20260323-omap4-fix-usb-support-v1-1-b668132124ac@bootlin.com> <20260327133612.6ee909fd@kemnade.info> Content-Language: en-US From: Thomas Richard In-Reply-To: <20260327133612.6ee909fd@kemnade.info> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hello Andreas, Thanks for the review. On 3/27/26 1:36 PM, Andreas Kemnade wrote: > On Mon, 23 Mar 2026 16:02:42 +0100 > Thomas Richard wrote: > >> Add support for the pbias SIM regulator found on OMAP4 (for USB I/O cell). >> >> Signed-off-by: Thomas Richard >> --- >> drivers/regulator/pbias-regulator.c | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/drivers/regulator/pbias-regulator.c b/drivers/regulator/pbias-regulator.c >> index cd5a0d7e44555f04d1e44470036c6e3d9feb7be6..10c4940e73635293bebd26bf99a9067eb6e39107 100644 >> --- a/drivers/regulator/pbias-regulator.c >> +++ b/drivers/regulator/pbias-regulator.c >> @@ -81,6 +81,16 @@ static const struct pbias_reg_info pbias_sim_omap3 = { >> .name = "pbias_sim_omap3" >> }; >> >> +static const struct pbias_reg_info pbias_sim_omap4 = { >> + .enable = BIT(28) | BIT(20), >> + .enable_mask = BIT(31) | BIT(28) | BIT(20), >> + .vmode = BIT(31), > > BIT(27)? or am I mixing something up? No you're right, I did a mistake. I'll send a v2 in the next few days to address this, Mark's and Conor's feedback, as well as few other issues I identified. Best Regards, Thomas