From: Imre Deak <imre.deak@nokia.com>
To: ext Brian Swetland <swetland@google.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: omapfb -- panel initialization inflexibility
Date: Mon, 05 Dec 2005 14:35:54 +0200 [thread overview]
Message-ID: <1133786154.7902.11.camel@localhost.localdomain> (raw)
In-Reply-To: <20051203034219.GA1516@localhost.localdomain>
Actually there is no requirement on calling panel->enable() before
omapfb_set_update_mode(), which enables the LCD DMA. It's even possible
to enable / disable the panel while having the LCD DMA active.
So lets simply switch the order of the two calls in omapfb_probe and the
suspend / resume functions. Please send a patch.
--Imre
On Fri, 2005-12-02 at 19:42 -0800, ext Brian Swetland wrote:
> I have an lcd panel connected to a omap730 based system that *requires*
> that MCK, HSYNC, and VSYNC are active when it is powered on. It will
> not initialize correctly otherwise.
>
> I've modified my omapfb driver so that there is a new OMAP_LCDC_*
> flag (OMAP_LCDC_PANEL_INIT_AFTER_LCDC) that determines if the
> enable hook is called where it is in the existing driver, or if
> it is called after omapfb_set_update_mode() returns.
>
> Any objections to this workaround? Any suggestions for a better
> name for the flag? Is there a better value than 0x200 for the flag?
>
> Thanks,
>
> Brian
> _______________________________________________
> Linux-omap-open-source mailing list
> Linux-omap-open-source@linux.omap.com
> http://linux.omap.com/mailman/listinfo/linux-omap-open-source
next prev parent reply other threads:[~2005-12-05 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-03 3:42 omapfb -- panel initialization inflexibility Brian Swetland
2005-12-05 12:35 ` Imre Deak [this message]
2005-12-05 13:49 ` [PATCH] omapfb: panel enable/disable reordering Brian Swetland
2005-12-20 12:15 ` Juha Yrjölä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1133786154.7902.11.camel@localhost.localdomain \
--to=imre.deak@nokia.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox