From: "Juha Yrjölä" <juha.yrjola@nokia.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: "Anderson.Briglia@indt.org.br" <Anderson.Briglia@indt.org.br>,
linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] MMC - CONFIG_HOTPLUG support
Date: Mon, 19 Dec 2005 17:44:41 +0200 [thread overview]
Message-ID: <1135007081.12906.25.camel@two.research.nokia.com> (raw)
In-Reply-To: <20051219130436.GC11932@flint.arm.linux.org.uk>
On Mon, 2005-12-19 at 13:04 +0000, Russell King - ARM Linux wrote:
> > As we can see on usb core driver, there's a compiler directive that
> > bypass the hotplug function if the CONFIG_HOTPLUG is not selected.
> > I think I could add this "support" on the MMC driver. Just a
> > optimization.
>
> Just because some other subsystem does something does not make it
> right for others to do the same. I'd like you to explain:
>
> 1. what additional support this patch gives us.
> 2. what the nature of the optimisation is.
With the patch the kernel text segment becomes a wee bit smaller if
certain criteria is met; that much should be obvious.
It's a trivial patch, true, but quite a valid one. If the MMC hotplug
function is not to be called from anywhere, no reason to waste space in
compiling it in.
Cheers,
Juha
next prev parent reply other threads:[~2005-12-19 15:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-16 19:50 [PATCH] MMC - CONFIG_HOTPLUG support Anderson Briglia
2005-12-16 21:58 ` Russell King - ARM Linux
2005-12-19 12:52 ` Anderson.Briglia
2005-12-19 13:04 ` Russell King - ARM Linux
2005-12-19 15:44 ` Juha Yrjölä [this message]
2005-12-19 16:02 ` Anderson.Briglia
2005-12-24 22:35 ` Russell King - ARM Linux
2005-12-26 18:46 ` Anderson.Briglia
2005-12-31 16:00 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1135007081.12906.25.camel@two.research.nokia.com \
--to=juha.yrjola@nokia.com \
--cc=Anderson.Briglia@indt.org.br \
--cc=linux-omap-open-source@linux.omap.com \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox