public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: "Juha Yrjölä" <juha.yrjola@nokia.com>
To: Komal Shah <komal_shah802003@yahoo.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] fix watchdog
Date: Mon, 19 Dec 2005 18:20:05 +0200	[thread overview]
Message-ID: <1135009205.12906.28.camel@two.research.nokia.com> (raw)
In-Reply-To: <20051218140922.88154.qmail@web32915.mail.mud.yahoo.com>

On Sun, 2005-12-18 at 06:09 -0800, ext Komal Shah wrote:

> Change .driver_name from "omap-wdt" to "omap_wdt".

Why?

Instead of explaining _what_ you do in the patch comments, you should
explain _why_, especially in the case of a trivial patch like this.

Cheers,
Juha

  reply	other threads:[~2005-12-19 16:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-18 14:09 [PATCH] fix watchdog Komal Shah
2005-12-19 16:20 ` Juha Yrjölä [this message]
2005-12-19 16:31   ` Komal Shah
2005-12-20 11:25     ` Juha Yrjölä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1135009205.12906.28.camel@two.research.nokia.com \
    --to=juha.yrjola@nokia.com \
    --cc=komal_shah802003@yahoo.com \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox