[PATCH] fix watchdog

[PATCH] fix watchdog

[Komal Shah]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

Tony,

Change .driver_name from "omap-wdt" to "omap_wdt".

Signed-off-by: Komal Shah <komal_shah802003@yahoo.com>

---Komal Shah
http://komalshah.blogspot.com/

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

[-- Attachment #2: 3502949089-fix-watchdog.patch --]
[-- Type: text/plain, Size: 377 bytes --]

diff --git a/drivers/char/watchdog/omap_wdt.c b/drivers/char/watchdog/omap_wdt.c
index 9904165..8f6fa68 100644
--- a/drivers/char/watchdog/omap_wdt.c
+++ b/drivers/char/watchdog/omap_wdt.c
@@ -362,7 +362,7 @@ static struct platform_driver omap_wdt_d
 	.resume		= omap_wdt_resume,
 	.driver		= {
 		.owner	= THIS_MODULE,
-		.name	= "omap-wdt",
+		.name	= "omap_wdt",
 	},
 };
 

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] fix watchdog

[Juha Yrjölä]

On Sun, 2005-12-18 at 06:09 -0800, ext Komal Shah wrote:

> Change .driver_name from "omap-wdt" to "omap_wdt".

Why?

Instead of explaining _what_ you do in the patch comments, you should
explain _why_, especially in the case of a trivial patch like this.

Cheers,
Juha

Re: [PATCH] fix watchdog

[Komal Shah]

> Why?
> 
> Instead of explaining _what_ you do in the patch comments, you should
> explain _why_, especially in the case of a trivial patch like 
> this.

Ok, I had made a mistake while generating the patch of omap_wdt.c for
"[PATCH] ARCH: OMAP omap-wdt: use struct platform_driver"


"-static struct device_driver omap_wdt_driver = {
- .name = "omap_wdt",
- .bus = &platform_bus_type,
- .probe = omap_wdt_probe,
- .shutdown = omap_wdt_shutdown,
- .remove = __exit_p(omap_wdt_remove),
- .suspend = omap_wdt_suspend,
- .resume = omap_wdt_resume,
+static struct platform_driver omap_wdt_driver = {
+ .probe = omap_wdt_probe,
+ .remove = omap_wdt_remove,
+ .shutdown = omap_wdt_shutdown,
+ .suspend = omap_wdt_suspend,
+ .resume = omap_wdt_resume,
+ .driver = {
+ .owner = THIS_MODULE,
+ .name = "omap-wdt",
+ },
};
 
In that I had mistakenly changed original driver name from "omap_wdt"
which matches with one in "devices.c" to "omap-wdt". So, you know the
effect...

The current patch reverts it back....

---Komal Shah
http://komalshah.blogspot.com/

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

Re: [PATCH] fix watchdog

[Juha Yrjölä]

On Mon, 2005-12-19 at 08:31 -0800, ext Komal Shah wrote:

> In that I had mistakenly changed original driver name from "omap_wdt"
> which matches with one in "devices.c" to "omap-wdt". So, you know the
> effect...
> 
> The current patch reverts it back....

Okay, applied.

Cheers,
Juha