From: "Juha Yrjölä" <juha.yrjola@nokia.com>
To: ext Komal Shah <komal_shah802003@yahoo.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] keypad platform_data and 24xx support refresh
Date: Mon, 16 Jan 2006 20:17:33 +0200 [thread overview]
Message-ID: <1137435453.12289.51.camel@two.research.nokia.com> (raw)
In-Reply-To: <20060116172406.3860.qmail@web32905.mail.mud.yahoo.com>
On Mon, 2006-01-16 at 09:24 -0800, ext Komal Shah wrote:
> > > +#ifdef CONFIG_MACH_OMAP_H4
> > > +static void set_col_gpio_val(u8 value)
> >
> > Not H4 but OMAP2.
>
> Why? If 2430 falls into OMAP2 class then it's EVM design for keyboard
> is using TWL4030 i2c interface to read the values. Richard can clarify
> on this.
Only generic keypad drivers are supposed to live in omap-keypad.c. I
had the impression that using GPIOs is the standard way of implementing
a keypad on OMAP2xxx CPUs (if you don't use an external keypad chip,
that is). Is this not the case? Keypads handled by companion chips
most likely will not share a lot of code with the OMAP-specific driver,
so they naturally belong to a separate driver.
Cheers,
Juha
next prev parent reply other threads:[~2006-01-16 18:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-15 10:27 [PATCH] keypad platform_data and 24xx support refresh Komal Shah
2006-01-15 16:25 ` Juha Yrjölä
2006-01-16 17:24 ` Komal Shah
2006-01-16 18:17 ` Juha Yrjölä [this message]
2006-01-17 5:25 ` Komal Shah
-- strict thread matches above, loose matches on Subject: below --
2006-01-16 17:29 Woodruff, Richard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1137435453.12289.51.camel@two.research.nokia.com \
--to=juha.yrjola@nokia.com \
--cc=komal_shah802003@yahoo.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox