From: "Juha Yrjölä" <juha.yrjola@nokia.com>
To: ext Komal Shah <komal_shah802003@yahoo.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: OMAP: Update OMAP keypad driver
Date: Mon, 13 Feb 2006 10:56:51 +0200 [thread overview]
Message-ID: <1139821011.5208.11.camel@two.research.nokia.com> (raw)
In-Reply-To: <20060213074100.42397.qmail@web32910.mail.mud.yahoo.com>
Hi Komal,
On Sun, 2006-02-12 at 23:41 -0800, ext Komal Shah wrote:
> - if (cpu_is_omap24xx() && omap_has_menelaus()) {
> - row_gpios[5] = 0;
> - col_gpios[2] = 15;
> - col_gpios[6] = 18;
> - }
> -
>
> May I know, where you have moved this? As discussed earlier here, it
> should be in the board specific file, but I don't find it there. _or_
> are you planning this in the next patch.?
I was the one who removed that, since it breaks keypad support on all
OMAP24xx boards (except H4, I presume) that have Menelaus on them. And
there are quite a few of those.
Please submit a patch that moves the stuff above into board-h4.c.
Cheers,
Juha
next prev parent reply other threads:[~2006-02-13 8:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-13 7:41 OMAP: Update OMAP keypad driver Komal Shah
2006-02-13 8:56 ` Juha Yrjölä [this message]
2006-02-17 15:12 ` Komal Shah
2006-02-17 16:30 ` David Weinehall
2006-02-17 21:06 ` Komal Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1139821011.5208.11.camel@two.research.nokia.com \
--to=juha.yrjola@nokia.com \
--cc=komal_shah802003@yahoo.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox