OMAP: Update OMAP keypad driver

OMAP: Update OMAP keypad driver

[Komal Shah]

Hiroshi,

- if (cpu_is_omap24xx() && omap_has_menelaus()) {
- row_gpios[5] = 0;
- col_gpios[2] = 15;
- col_gpios[6] = 18;
- }
-

May I know, where you have moved this? As discussed earlier here, it
should be in the board specific file, but I don't find it there. _or_
are you planning this in the next patch.?

---Komal Shah
http://komalshah.blogspot.com/

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

Re: OMAP: Update OMAP keypad driver

[Juha Yrjölä]

Hi Komal,

On Sun, 2006-02-12 at 23:41 -0800, ext Komal Shah wrote:

> - if (cpu_is_omap24xx() && omap_has_menelaus()) {
> - row_gpios[5] = 0;
> - col_gpios[2] = 15;
> - col_gpios[6] = 18;
> - }
> -
> 
> May I know, where you have moved this? As discussed earlier here, it
> should be in the board specific file, but I don't find it there. _or_
> are you planning this in the next patch.?

I was the one who removed that, since it breaks keypad support on all
OMAP24xx boards (except H4, I presume) that have Menelaus on them.  And
there are quite a few of those.

Please submit a patch that moves the stuff above into board-h4.c.

Cheers,
Juha

Re: OMAP: Update OMAP keypad driver

[Komal Shah]

--- Juha Yrjölä <juha.yrjola@nokia.com> wrote:

> 
> I was the one who removed that, since it breaks keypad support on all
> OMAP24xx boards (except H4, I presume) that have Menelaus on them. 
> And
> there are quite a few of those.
> 
> Please submit a patch that moves the stuff above into board-h4.c.
> 

I will submit that patch soon, having some problem in H4 setup right
now.

Before that can't we convert the code below in keypad to

253 down(&kp_enable_mutex);
254 	if (state != kp_enable) {
255 	if (state)
256 		enable_irq(INT_KEYBOARD);
257 	else
258 		disable_irq(INT_KEYBOARD);
259 		kp_enable = state;
260 }
261 up(&kp_enable_mutex);

- Use mutex apis.
- and use platform driver data omap_kp->irq instead of INT_KEYBOARD.

Also as of now, I am not getting interrupt on H4 Menelaus keypad, looks
like due to trigger flags changes...or something else.

---Komal Shah
http://komalshah.blogspot.com/

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

Re: OMAP: Update OMAP keypad driver

[David Weinehall]

On Fri, Feb 17, 2006 at 07:12:07AM -0800, Komal Shah wrote:
> --- Juha Yrjölä <juha.yrjola@nokia.com> wrote:
> 
> > 
> > I was the one who removed that, since it breaks keypad support on all
> > OMAP24xx boards (except H4, I presume) that have Menelaus on them. 
> > And
> > there are quite a few of those.
> > 
> > Please submit a patch that moves the stuff above into board-h4.c.
> > 
> 
> I will submit that patch soon, having some problem in H4 setup right
> now.
> 
> Before that can't we convert the code below in keypad to
> 
> 253 down(&kp_enable_mutex);
> 254 	if (state != kp_enable) {
> 255 	if (state)
> 256 		enable_irq(INT_KEYBOARD);
> 257 	else
> 258 		disable_irq(INT_KEYBOARD);
> 259 		kp_enable = state;
> 260 }
> 261 up(&kp_enable_mutex);

Either you've indented incorrectly here, or you have a bug.

[snip]


Regards: David Weinehall
-- 
 /) David Weinehall <tao@acc.umu.se> /) Northern lights wander      (\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\)  http://www.acc.umu.se/~tao/    (/   Full colour fire           (/

Re: OMAP: Update OMAP keypad driver

[Komal Shah]

--- David Weinehall <tao@acc.umu.se> wrote:
> > Before that can't we convert the code below in keypad to
> > 
> > 253 down(&kp_enable_mutex);
> > 254 	if (state != kp_enable) {
> > 255 	if (state)
> > 256 		enable_irq(INT_KEYBOARD);
> > 257 	else
> > 258 		disable_irq(INT_KEYBOARD);
> > 259 		kp_enable = state;
> > 260 }
> > 261 up(&kp_enable_mutex);
> 
> Either you've indented incorrectly here, or you have a bug.

Yes, indentation got lost while I had copy pasted code from Firefox to
e-mail editor, but my point was to use mutex apis and replace
INT_KEYBOARD with platform driver data instead.

---Komal Shah
http://komalshah.blogspot.com/

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com