Re: [PATCH 1/4] i2c: clean add_children a bit

[Felipe Balbi <me@felipebalbi.com>]

Hi Dave,

On Thu, 25 Sep 2008 10:28:00 -0700, David Brownell <david-b@pacbell.net>
wrote:
> On Thursday 25 September 2008, Felipe Balbi wrote:
>> Clean up add_children a bit before adding more children
>> to twl4030-core.c
>>
>> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> 
> ACK, except for:
> 
>> --- a/include/linux/i2c/twl4030.h
>> +++ b/include/linux/i2c/twl4030.h
>> @@ -145,4 +145,10 @@ int twl4030_free_gpio(int gpio);
>>  	static inline int twl4030charger_usb_en(int enable) { return 0; }
>>  #endif
>>
>> +#if defined(CONFIG_RTC_DRV_TWL4030) ||
> defined(CONFIG_RTC_DRV_TWL4030_MODULE)
>> +#define twl_has_rtc()	(1)
>> +#else
>> +#define twl_has_rtc()	(0)
>> +#endif
> 
> Who else would need this, other than the core?
> I think the answer is "nobody" ... so these macros
> belong in the core itself, not a public header.
> 
> Also:  parens not appropriate around those values; and
> "true" and "false" values would be a bit more clear...

you sure got a point here, I'll update the series when
I get to work tomorrow (actualy today, already 1am).

Anyways, I'll update and resend the series.

-- 
Best Regards,

Felipe Balbi
http://blog.felipebalbi.com
me@felipebalbi.com