* [PATCH] Make omap_bl build again after API change.
@ 2007-01-05 0:26 Andrzej Zaborowski
2007-01-09 23:32 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Andrzej Zaborowski @ 2007-01-05 0:26 UTC (permalink / raw)
To: Linux-OMAP
[Oops, I sent this to Dirk eariler and forgot to CC the list.]
Make omap_bl build again after API change.
Breakage spotted by Dirk Behme.
Also remove comment about API glitch which has just been fixed.
Signed-off-by: Andrzej Zaborowski <balrog@zabor.org>
---
drivers/video/backlight/omap_bl.c | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/video/backlight/omap_bl.c b/drivers/video/backlight/omap_bl.c
index 22189b1..3b57b27 100644
--- a/drivers/video/backlight/omap_bl.c
+++ b/drivers/video/backlight/omap_bl.c
@@ -152,12 +152,8 @@ static int omapbl_probe(struct platform_
if (unlikely(!bl))
return -ENOMEM;
- /* REVISIT backlight API glitch: we can't associate the
- * class device with "pdev" ... probably pass &pdev->dev
- * instead of a string.
- */
-
- dev = backlight_device_register("omap-bl", bl, &omapbl_data);
+ dev = backlight_device_register("omap-bl", &pdev->dev,
+ bl, &omapbl_data);
if (IS_ERR(dev)) {
kfree(bl);
return PTR_ERR(dev);
--
1.4.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Make omap_bl build again after API change.
2007-01-05 0:26 [PATCH] Make omap_bl build again after API change Andrzej Zaborowski
@ 2007-01-09 23:32 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2007-01-09 23:32 UTC (permalink / raw)
To: balrogg; +Cc: Linux-OMAP
* Andrzej Zaborowski <balrog@zabor.org> [070104 15:26]:
> [Oops, I sent this to Dirk eariler and forgot to CC the list.]
> Make omap_bl build again after API change.
>
> Breakage spotted by Dirk Behme.
> Also remove comment about API glitch which has just been fixed.
>
> Signed-off-by: Andrzej Zaborowski <balrog@zabor.org>
> ---
> drivers/video/backlight/omap_bl.c | 8 ++------
> 1 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/video/backlight/omap_bl.c b/drivers/video/backlight/omap_bl.c
> index 22189b1..3b57b27 100644
> --- a/drivers/video/backlight/omap_bl.c
> +++ b/drivers/video/backlight/omap_bl.c
> @@ -152,12 +152,8 @@ static int omapbl_probe(struct platform_
> if (unlikely(!bl))
> return -ENOMEM;
>
> - /* REVISIT backlight API glitch: we can't associate the
> - * class device with "pdev" ... probably pass &pdev->dev
> - * instead of a string.
> - */
> -
> - dev = backlight_device_register("omap-bl", bl, &omapbl_data);
> + dev = backlight_device_register("omap-bl", &pdev->dev,
> + bl, &omapbl_data);
> if (IS_ERR(dev)) {
> kfree(bl);
> return PTR_ERR(dev);
Pushing today.
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-01-09 23:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-05 0:26 [PATCH] Make omap_bl build again after API change Andrzej Zaborowski
2007-01-09 23:32 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox