From: Kevin Hilman <khilman@mvista.com>
To: linux-omap-open-source@linux.omap.com
Subject: [PATCH] ARM: OMAP: Correct use of CONTROL_ regs for OMAP2
Date: Wed, 22 Aug 2007 13:36:53 -0700 [thread overview]
Message-ID: <11878150131374-git-send-email-khilman@mvista.com> (raw)
The system control module regs have a different base on 2420 and 2430.
Fix them to work on 2430.
Signed-off-by: Kevin Hilman <khilman@mvista.com>
---
arch/arm/mach-omap2/board-h4.c | 2 +-
arch/arm/plat-omap/devices.c | 4 ++--
include/asm-arm/arch-omap/omap24xx.h | 10 +++++++---
3 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/arch/arm/mach-omap2/board-h4.c b/arch/arm/mach-omap2/board-h4.c
index a4defbf..df26135 100644
--- a/arch/arm/mach-omap2/board-h4.c
+++ b/arch/arm/mach-omap2/board-h4.c
@@ -267,7 +267,7 @@ static struct platform_device *h4_devices[] __initdata = {
/* 2420 Sysboot setup (2430 is different) */
static u32 get_sysboot_value(void)
{
- return (omap_readl(OMAP24XX_CONTROL_STATUS) & 0xFFF);
+ return (omap_readl(OMAP2_CONTROL_STATUS) & 0xFFF);
}
/* FIXME: This function should be moved to some other file, gpmc.c? */
diff --git a/arch/arm/plat-omap/devices.c b/arch/arm/plat-omap/devices.c
index 0c0ecd7..c2828fe 100644
--- a/arch/arm/plat-omap/devices.c
+++ b/arch/arm/plat-omap/devices.c
@@ -345,9 +345,9 @@ static void __init omap_init_mmc(void)
* Module Input Clock selection
*/
if (cpu_is_omap24xx()) {
- u32 v = omap_readl(OMAP24XX_CONTROL_DEVCONF);
+ u32 v = omap_readl(OMAP2_CONTROL_DEVCONF);
v |= (1 << 24);
- omap_writel(v, OMAP24XX_CONTROL_DEVCONF);
+ omap_writel(v, OMAP2_CONTROL_DEVCONF);
}
}
mmc1_conf = *mmc;
diff --git a/include/asm-arm/arch-omap/omap24xx.h b/include/asm-arm/arch-omap/omap24xx.h
index e552ce8..2e944a1 100644
--- a/include/asm-arm/arch-omap/omap24xx.h
+++ b/include/asm-arm/arch-omap/omap24xx.h
@@ -41,9 +41,6 @@
#define OMAP24XX_IVA_INTC_BASE 0x40000000
#define IRQ_SIR_IRQ 0x0040
-#define OMAP24XX_CONTROL_DEVCONF (L4_24XX_BASE + 0x274)
-#define OMAP24XX_CONTROL_STATUS (L4_24XX_BASE + 0x2f8)
-
#define OMAP2420_CTRL_BASE L4_24XX_BASE
#define OMAP2420_32KSYNCT_BASE (L4_24XX_BASE + 0x4000)
#define OMAP2420_PRCM_BASE (L4_24XX_BASE + 0x8000)
@@ -106,5 +103,12 @@
#endif
+/* Control module */
+#define OMAP2_CONTROL_DEVCONF0 (OMAP2_CTRL_BASE + 0x274)
+#define OMAP2_CONTROL_DEVCONF1 (OMAP2_CTRL_BASE + 0x2e8)
+#define OMAP2_CONTROL_DEVCONF OMAP2_CONTROL_DEVCONF0
+
+#define OMAP2_CONTROL_STATUS (OMAP2_CTRL_BASE + 0x2f8)
+
#endif /* __ASM_ARCH_OMAP24XX_H */
--
1.5.2
next reply other threads:[~2007-08-22 20:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-22 20:36 Kevin Hilman [this message]
2007-08-24 12:08 ` [PATCH] ARM: OMAP: Correct use of CONTROL_ regs for OMAP2 Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11878150131374-git-send-email-khilman@mvista.com \
--to=khilman@mvista.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox