Re: [PATCH v3] Make the pr_*() family of macros in kernel.h complete

Andrew Morton
2007-09-14T20:18:28Z

On Fri, 14 Sep 2007 06:27:04 -0700 "Medve Emilian-EMMEDVE1" <Emilian.Medve@freescale.com> wrote:

> I realize this e-mail might be nuisance and time waster for you but I'm
> in need of advice. I apologize in advance for any commonsense cultural
> conventions I'm breaking.
>
> I sent the below patch to four e-mail lists and it lead to orthogonal
> conversations about how the entire kernel logging system/mechanisms need
> to be re-written and thus such incremental improvements as these get out
> of focus...
>
> In this case I started needing pr_err() and discovered that is defined
> already four times but not with global visibility as some other pr_*()
> from kernel.h (a subset of the entire family). I chose not to define it
> yet the fifth time but clean up the existing definitions and complete
> the family. For some reason it didn't go through even though I had some
> positive feedback. Now it seems I'm encouraged to really define the
> pr_err() for the fifth time... Not quite sure what to do...

I normally troll the lkml list for patches like this and will sweep them
up. But I'm presently 1400 messages in arrears so there is some latency.

I'll go grab this patch.