RE: [PATCH v3] Make the pr_*() family of macros in kernel.h complete

Medve Emilian-EMMEDVE1
2007-09-12T18:44:56Z

> -----Original Message-----
> From: Jan Engelhardt [mailto:jengelh@computergmbh.de]
> Sent: Wednesday, September 12, 2007 1:04 PM
> To: Medve Emilian-EMMEDVE1
> Cc: linux-kernel@vger.kernel.org; netdev@vger.kernel.org;
> i2c@lm-sensors.org; linux-omap-open-source@linux.omap.com
> Subject: Re: [PATCH v3] Make the pr_*() family of macros in
> kernel.h complete
>
>
> On Sep 12 2007 11:39, Emil Medve wrote:
> >
> >Other/Some pr_*() macros are already defined in kernel.h,
> but pr_err() was defined
> >multiple times in several other places
>
> Note http://lkml.org/lkml/2007/8/4/30 .

Hi Jan,

I didn't see that thread before I submitted the patch... I don't want to
start the conversation from the top 'cause this is not a patch that
fixes some existing showstopper... however, I have two comments to make.
First, this patch doesn't have the trailing "\n" problem that one had.
Second, it seems that multiple people at different moments in time have
the same idea to complete and, more important, to use the pr_*() family
of macros because I guess it makes it easier to use them. In addition,
it would make it less likely for people to forget using the loglevel in
their kernel messages.

Is trying to add them a dead path? Thing is that the existing ones
suggest to, more or less, new people to the kernel that they should use
them and then discover the incompleteness/inconsistency...

Cheers,
Emil.