public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Igor Stoppa <igor.stoppa@nokia.com>
To: ext Kevin Hilman <khilman@mvista.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] ARM: OMAP: fix default sys_ck.rate for boot-time DPLL detection
Date: Mon, 22 Oct 2007 10:24:24 +0300	[thread overview]
Message-ID: <1193037864.29349.261.camel@localhost.localdomain> (raw)
In-Reply-To: <20071019211415.183990583@mvista.com>

Hi Kevin,
On Fri, 2007-10-19 at 14:14 -0700, ext Kevin Hilman wrote:
> In the clock init code, the DPLL value set by the bootloader is
> queried, but always turns zero due it's parent clock (sys_ck) having
> no default rate.  This results in the improper setting of the default
> PRCM rate-table entry and any queries of virt_prcm_set rate to return 0.
> 
> Following the example of the TI kernel, set the default sys_ck rate to
> 13MHz.  Could then be overridden in board setup code.

There should be an even cleaner way to handle that (but i have no code
to prove that it works =) since the boot rom already does auto-detection
of the oscillator to support serial flashing.

If it is possible to read the detected value then the code can be moved
to arch or even plat.

-- 
Cheers, Igor

Igor Stoppa <igor.stoppa@nokia.com>
(Nokia Multimedia - CP - OSSO / Helsinki, Finland)

  parent reply	other threads:[~2007-10-22  7:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-19 21:14 [PATCH] ARM: OMAP: fix default sys_ck.rate for boot-time DPLL detection Kevin Hilman
2007-10-22  0:11 ` Tony Lindgren
2007-10-22  7:24 ` Igor Stoppa [this message]
2007-10-22 12:37   ` [PATCH] ARM: OMAP: fix default sys_ck.rate for boot-time DPLLdetection Woodruff, Richard
2007-10-22 16:52     ` Kevin Hilman
2007-10-22 21:46       ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1193037864.29349.261.camel@localhost.localdomain \
    --to=igor.stoppa@nokia.com \
    --cc=khilman@mvista.com \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox