From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: [1/3] mfd/omap-usb-tll: Delete two error messages for a failed memory allocation in usbtll_omap_probe() Date: Mon, 15 Jan 2018 17:21:47 +0100 Message-ID: <11eaf92d-3928-531f-35e8-fb5a60ff03e3@users.sourceforge.net> References: <7719b4e7-1081-6fa4-6f14-f45cf062482d@users.sourceforge.net> <20180115134101.GA6711@lenoch> <1ebb5ac5-aa4d-7c19-94db-210b518d562f@users.sourceforge.net> <20180115160522.GA2672@lenoch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20180115160522.GA2672@lenoch> Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org To: Ladislav Michl , linux-omap@vger.kernel.org Cc: Lee Jones , Tony Lindgren , LKML , kernel-janitors@vger.kernel.org List-Id: linux-omap@vger.kernel.org >>>> @@ -258,7 +256,6 @@ static int usbtll_omap_probe(struct platform_device *pdev) >>>> GFP_KERNEL); >>>> if (!tll->ch_clk) { >>>> ret = -ENOMEM; >>>> - dev_err(dev, "Couldn't allocate memory for channel clocks\n"); >>> >>> I'd either leave this one, just to know which allocation failed or better use >>> something like this … >> >> Are you aware on the structure for a Linux allocation failure report? > > Just created one (not OMAP and not this driver, but that does not matter now): Thanks for your example. > ---[ end trace 3c79eadf2363e939 ]--- > max9867: probe of 1-0018 failed with error -12 > > driver was instructed to alloc insane number of bytes using devm_kzalloc in > max9867_i2c_probe. > Now, if probe function calls devm_kzalloc two times and one of them fails, > you cannot easily say which one without looking at assembly listing. Will this situation change with any other implementation for such backtraces? > Or did I misunderstand your question? No. - It seems that we have found a “common wavelength”. Would it become acceptable to move the mentioned memory allocation into an additional function implementation so that you could see a difference from the function call stack dump already? Regards, Markus