public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: linux-arm-kernel@lists.arm.linux.org.uk
Cc: linux-omap@vger.kernel.org, Kevin Hilman <khilman@mvista.com>,
	Tony Lindgren <tony@atomide.com>
Subject: [PATCH 2/6] ARM: OMAP: Fix GPIO IRQ unmask
Date: Thu, 13 Mar 2008 17:45:15 +0200	[thread overview]
Message-ID: <1205423119-22292-3-git-send-email-tony@atomide.com> (raw)
In-Reply-To: <1205423119-22292-2-git-send-email-tony@atomide.com>

From: Kevin Hilman <khilman@mvista.com>

GPIO IRQ unmask doesn't actually do anything useful.  The problem is
hidden by a separate explicit mass unmask at the end of the chained
bank handler.

Signed-off-by: Kevin Hilman <khilman@mvista.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/plat-omap/gpio.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
index 66a1455..8c78e4e 100644
--- a/arch/arm/plat-omap/gpio.c
+++ b/arch/arm/plat-omap/gpio.c
@@ -1134,10 +1134,9 @@ static void gpio_mask_irq(unsigned int irq)
 static void gpio_unmask_irq(unsigned int irq)
 {
 	unsigned int gpio = irq - IH_GPIO_BASE;
-	unsigned int gpio_idx = get_gpio_index(gpio);
 	struct gpio_bank *bank = get_irq_chip_data(irq);
 
-	_set_gpio_irqenable(bank, gpio_idx, 1);
+	_set_gpio_irqenable(bank, gpio, 1);
 }
 
 static struct irq_chip gpio_irq_chip = {
-- 
1.5.3.6


  reply	other threads:[~2008-03-13 15:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-13 15:45 [PATCH 0/6] Few more omap fixes for 2.6.25 Tony Lindgren
2008-03-13 15:45 ` [PATCH 1/6] ARM: OMAP: Fix clockevent support for hrtimers Tony Lindgren
2008-03-13 15:45   ` Tony Lindgren [this message]
2008-03-13 15:45     ` [PATCH 3/6] ARM: OMAP: Fix missing makefile options Tony Lindgren
2008-03-13 15:45       ` [PATCH 4/6] ARM: OMAP: Fix chain_a_transfer return value Tony Lindgren
2008-03-13 15:45         ` [PATCH 5/6] ARM: OMAP: Fix DMA CLINK mask, clear spurious interrupt Tony Lindgren
2008-03-13 15:45           ` [PATCH 6/6] ARM: OMAP1: Fix typo in OMAP1 MPU clock source initialization Tony Lindgren
2008-03-20 14:43   ` [PATCH 1/6] ARM: OMAP: Fix clockevent support for hrtimers Russell King - ARM Linux
2008-03-20 15:03     ` Tony Lindgren
2008-03-13 23:19 ` [PATCH 0/6] Few more omap fixes for 2.6.25 Russell King - ARM Linux
2008-03-14  8:42   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1205423119-22292-3-git-send-email-tony@atomide.com \
    --to=tony@atomide.com \
    --cc=khilman@mvista.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox