From: Tony Lindgren <tony@atomide.com>
To: linux-arm-kernel@lists.arm.linux.org.uk
Cc: linux-omap@vger.kernel.org, "Gadiyar, Anand" <gadiyar@ti.com>,
Kevin Hilman <khilman@mvista.com>,
Tony Lindgren <tony@atomide.com>
Subject: [PATCH 5/6] ARM: OMAP: Fix DMA CLINK mask, clear spurious interrupt
Date: Thu, 13 Mar 2008 17:45:18 +0200 [thread overview]
Message-ID: <1205423119-22292-6-git-send-email-tony@atomide.com> (raw)
In-Reply-To: <1205423119-22292-5-git-send-email-tony@atomide.com>
From: Gadiyar, Anand <gadiyar@ti.com>
Fix CLINK mask, clear spurious interrupt.
Signed-off-by: Gadiyar, Anand <gadiyar@ti.com>
Signed-off-by: Kevin Hilman <khilman@mvista.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/plat-omap/dma.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
index 06293bf..7937406 100644
--- a/arch/arm/plat-omap/dma.c
+++ b/arch/arm/plat-omap/dma.c
@@ -1020,12 +1020,12 @@ static void create_dma_lch_chain(int lch_head, int lch_queue)
}
w = OMAP_DMA_CLNK_CTRL_REG(lch_head);
- w &= ~(0x0f);
+ w &= ~(0x1f);
w |= lch_queue;
OMAP_DMA_CLNK_CTRL_REG(lch_head) = w;
w = OMAP_DMA_CLNK_CTRL_REG(lch_queue);
- w &= ~(0x0f);
+ w &= ~(0x1f);
w |= (dma_chan[lch_queue].next_linked_ch);
OMAP_DMA_CLNK_CTRL_REG(lch_queue) = w;
}
@@ -1663,6 +1663,7 @@ static int omap2_dma_handle_ch(int ch)
if (!status) {
if (printk_ratelimit())
printk(KERN_WARNING "Spurious DMA IRQ for lch %d\n", ch);
+ omap_writel(1 << ch, OMAP_DMA4_IRQSTATUS_L0);
return 0;
}
if (unlikely(dma_chan[ch].dev_id == -1)) {
--
1.5.3.6
next prev parent reply other threads:[~2008-03-13 15:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-13 15:45 [PATCH 0/6] Few more omap fixes for 2.6.25 Tony Lindgren
2008-03-13 15:45 ` [PATCH 1/6] ARM: OMAP: Fix clockevent support for hrtimers Tony Lindgren
2008-03-13 15:45 ` [PATCH 2/6] ARM: OMAP: Fix GPIO IRQ unmask Tony Lindgren
2008-03-13 15:45 ` [PATCH 3/6] ARM: OMAP: Fix missing makefile options Tony Lindgren
2008-03-13 15:45 ` [PATCH 4/6] ARM: OMAP: Fix chain_a_transfer return value Tony Lindgren
2008-03-13 15:45 ` Tony Lindgren [this message]
2008-03-13 15:45 ` [PATCH 6/6] ARM: OMAP1: Fix typo in OMAP1 MPU clock source initialization Tony Lindgren
2008-03-20 14:43 ` [PATCH 1/6] ARM: OMAP: Fix clockevent support for hrtimers Russell King - ARM Linux
2008-03-20 15:03 ` Tony Lindgren
2008-03-13 23:19 ` [PATCH 0/6] Few more omap fixes for 2.6.25 Russell King - ARM Linux
2008-03-14 8:42 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205423119-22292-6-git-send-email-tony@atomide.com \
--to=tony@atomide.com \
--cc=gadiyar@ti.com \
--cc=khilman@mvista.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox