Re: [PATCH] i2c: tea5761: New-style i2c driver

[Eduardo Valentin <edubezval@gmail.com>]

Hi Jarkko,

Thanks for the review.

>On Thu, 27 Mar 2008 11:31:20 -0400
>"ext Eduardo Valentin" <edubezval@gmail.com> wrote:
>
>> From: Eduardo Valentin <eduardo.valentin@indt.org.br>
>> 
>> This patch updates the fm radio driver for tea5761 chip.
>> It also moves board dependent code to its correct board
>> file place.
>> 
>Good move forward!
>
>Any plans to send this driver with Kconfig & Makefile modifications to
>relevant V4L etc mailing list?

Yes, I can send them to V4L2 mailing list after we have them in a good shape.

>
>Note there are three minor warnings if you run your patch with
>scripts/checkpatch.pl.

Yes, thanks. I'm sending an updated version.

>
>You could also remove these two headers files below since they are not
>needed anymore.

Already done in this new version.

>
>> diff --git a/drivers/media/radio/radio-tea5761.c
>> b/drivers/media/radio/radio-tea5761.c index ac0f621..2341e66 100644
>> --- a/drivers/media/radio/radio-tea5761.c
>> +++ b/drivers/media/radio/radio-tea5761.c
>@@ -23,8 +23,8 @@
> #include <linux/i2c.h>
> #include <linux/delay.h>
> #include <media/v4l2-common.h>
>-#include <asm/arch/gpio.h>
>-#include <asm/arch/board.h>
>
>
>-- 
>Jarkko

Cheers,

Eduardo Valentin