* [PATCH] Fix TUSB6010 ID register offsets.
@ 2008-03-29 17:01 Andrzej Zaborowski
0 siblings, 0 replies; 7+ messages in thread
From: Andrzej Zaborowski @ 2008-03-29 17:01 UTC (permalink / raw)
To: linux-omap
From: Andrzej Zaborowski <balrog@zabor.org>
I have no access to the docs for this chip but I'm pretty sure the current
address of the two DIDR1 registers is wrong because it's outside the
TUSB-specific register space. The modified address in turn has a good
chance to be correct.
Signed-off-by: Andrzej Zaborowski <balrog@zabor.org>
---
drivers/usb/musb/tusb6010.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/musb/tusb6010.h b/drivers/usb/musb/tusb6010.h
index bb25c3b..a40123d 100644
--- a/drivers/usb/musb/tusb6010.h
+++ b/drivers/usb/musb/tusb6010.h
@@ -225,8 +225,8 @@ extern void tusb_allow_idle(struct musb *musb, u32 wakeup_enables);
#define TUSB_PROD_TEST_RESET_VAL 0xa596
#define TUSB_EP_FIFO(ep) (TUSB_FIFO_BASE + (ep) * 0x20)
-#define TUSB_DIDR1_LO 0x1f8
-#define TUSB_DIDR1_HI 0x1fc
+#define TUSB_DIDR1_LO (TUSB_FIFO_BASE + 0x1f8)
+#define TUSB_DIDR1_HI (TUSB_FIFO_BASE + 0x1fc)
#define TUSB_DIDR1_HI_CHIP_REV(v) (((v) >> 17) & 0xf)
#define TUSB_DIDR1_HI_REV_20 0
#define TUSB_DIDR1_HI_REV_30 1
--
1.5.3.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] Fix TUSB6010 ID register offsets.
@ 2008-03-29 17:52 Andrzej Zaborowski
2008-03-31 7:58 ` Tony Lindgren
2008-04-02 10:15 ` Felipe Balbi
0 siblings, 2 replies; 7+ messages in thread
From: Andrzej Zaborowski @ 2008-03-29 17:52 UTC (permalink / raw)
To: linux-omap
From: Andrzej Zaborowski <balrog@zabor.org>
[Sorry, the previous patch was a copy/paste mistake, this one should be
better]
I have no access to the docs for this chip but I'm pretty sure the current
address of the two DIDR1 registers is wrong because it's outside the
TUSB-specific register space. The modified address in turn has a good
chance to be correct.
Signed-off-by: Andrzej Zaborowski <balrog@zabor.org>
---
drivers/usb/musb/tusb6010.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/musb/tusb6010.h b/drivers/usb/musb/tusb6010.h
index bb25c3b..f2036ef 100644
--- a/drivers/usb/musb/tusb6010.h
+++ b/drivers/usb/musb/tusb6010.h
@@ -225,8 +225,8 @@ extern void tusb_allow_idle(struct musb *musb, u32 wakeup_enables);
#define TUSB_PROD_TEST_RESET_VAL 0xa596
#define TUSB_EP_FIFO(ep) (TUSB_FIFO_BASE + (ep) * 0x20)
-#define TUSB_DIDR1_LO 0x1f8
-#define TUSB_DIDR1_HI 0x1fc
+#define TUSB_DIDR1_LO (TUSB_SYS_REG_BASE + 0x1f8)
+#define TUSB_DIDR1_HI (TUSB_SYS_REG_BASE + 0x1fc)
#define TUSB_DIDR1_HI_CHIP_REV(v) (((v) >> 17) & 0xf)
#define TUSB_DIDR1_HI_REV_20 0
#define TUSB_DIDR1_HI_REV_30 1
--
1.5.3.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Fix TUSB6010 ID register offsets.
2008-03-29 17:52 [PATCH] Fix TUSB6010 ID register offsets Andrzej Zaborowski
@ 2008-03-31 7:58 ` Tony Lindgren
2008-03-31 8:58 ` Felipe Balbi
2008-04-02 10:15 ` Felipe Balbi
1 sibling, 1 reply; 7+ messages in thread
From: Tony Lindgren @ 2008-03-31 7:58 UTC (permalink / raw)
To: Andrzej Zaborowski; +Cc: linux-omap
* Andrzej Zaborowski <balrogg@gmail.com> [080329 18:48]:
> From: Andrzej Zaborowski <balrog@zabor.org>
>
> [Sorry, the previous patch was a copy/paste mistake, this one should be
> better]
>
> I have no access to the docs for this chip but I'm pretty sure the current
> address of the two DIDR1 registers is wrong because it's outside the
> TUSB-specific register space. The modified address in turn has a good
> chance to be correct.
>
> Signed-off-by: Andrzej Zaborowski <balrog@zabor.org>
> ---
> drivers/usb/musb/tusb6010.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/musb/tusb6010.h b/drivers/usb/musb/tusb6010.h
> index bb25c3b..f2036ef 100644
> --- a/drivers/usb/musb/tusb6010.h
> +++ b/drivers/usb/musb/tusb6010.h
> @@ -225,8 +225,8 @@ extern void tusb_allow_idle(struct musb *musb, u32 wakeup_enables);
> #define TUSB_PROD_TEST_RESET_VAL 0xa596
> #define TUSB_EP_FIFO(ep) (TUSB_FIFO_BASE + (ep) * 0x20)
>
> -#define TUSB_DIDR1_LO 0x1f8
> -#define TUSB_DIDR1_HI 0x1fc
> +#define TUSB_DIDR1_LO (TUSB_SYS_REG_BASE + 0x1f8)
> +#define TUSB_DIDR1_HI (TUSB_SYS_REG_BASE + 0x1fc)
> #define TUSB_DIDR1_HI_CHIP_REV(v) (((v) >> 17) & 0xf)
> #define TUSB_DIDR1_HI_REV_20 0
> #define TUSB_DIDR1_HI_REV_30 1
This looks like a valid fix. Hmm, I guess we've had some unnecessary
software workarounds for tusb3.1 chips happening :)
Tony
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Fix TUSB6010 ID register offsets.
2008-03-31 7:58 ` Tony Lindgren
@ 2008-03-31 8:58 ` Felipe Balbi
2008-03-31 12:52 ` andrzej zaborowski
0 siblings, 1 reply; 7+ messages in thread
From: Felipe Balbi @ 2008-03-31 8:58 UTC (permalink / raw)
To: Tony Lindgren; +Cc: Andrzej Zaborowski, linux-omap
On Mon, Mar 31, 2008 at 10:58:11AM +0300, Tony Lindgren wrote:
> * Andrzej Zaborowski <balrogg@gmail.com> [080329 18:48]:
> > From: Andrzej Zaborowski <balrog@zabor.org>
> >
> > [Sorry, the previous patch was a copy/paste mistake, this one should be
> > better]
> >
> > I have no access to the docs for this chip but I'm pretty sure the current
> > address of the two DIDR1 registers is wrong because it's outside the
> > TUSB-specific register space. The modified address in turn has a good
> > chance to be correct.
> >
> > Signed-off-by: Andrzej Zaborowski <balrog@zabor.org>
> > ---
> > drivers/usb/musb/tusb6010.h | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/usb/musb/tusb6010.h b/drivers/usb/musb/tusb6010.h
> > index bb25c3b..f2036ef 100644
> > --- a/drivers/usb/musb/tusb6010.h
> > +++ b/drivers/usb/musb/tusb6010.h
> > @@ -225,8 +225,8 @@ extern void tusb_allow_idle(struct musb *musb, u32 wakeup_enables);
> > #define TUSB_PROD_TEST_RESET_VAL 0xa596
> > #define TUSB_EP_FIFO(ep) (TUSB_FIFO_BASE + (ep) * 0x20)
> >
> > -#define TUSB_DIDR1_LO 0x1f8
> > -#define TUSB_DIDR1_HI 0x1fc
> > +#define TUSB_DIDR1_LO (TUSB_SYS_REG_BASE + 0x1f8)
> > +#define TUSB_DIDR1_HI (TUSB_SYS_REG_BASE + 0x1fc)
> > #define TUSB_DIDR1_HI_CHIP_REV(v) (((v) >> 17) & 0xf)
> > #define TUSB_DIDR1_HI_REV_20 0
> > #define TUSB_DIDR1_HI_REV_30 1
>
> This looks like a valid fix. Hmm, I guess we've had some unnecessary
> software workarounds for tusb3.1 chips happening :)
Ugh, I'm out for today and tomorrow but I'll test on wednesday and make
sure it works.
thanks, btw.
--
Best Regards,
Felipe Balbi
me@felipebalbi.com
http://blog.felipebalbi.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Fix TUSB6010 ID register offsets.
2008-03-31 8:58 ` Felipe Balbi
@ 2008-03-31 12:52 ` andrzej zaborowski
0 siblings, 0 replies; 7+ messages in thread
From: andrzej zaborowski @ 2008-03-31 12:52 UTC (permalink / raw)
To: me; +Cc: Tony Lindgren, linux-omap
On 31/03/2008, Felipe Balbi <me@felipebalbi.com> wrote:
> On Mon, Mar 31, 2008 at 10:58:11AM +0300, Tony Lindgren wrote:
> > * Andrzej Zaborowski <balrogg@gmail.com> [080329 18:48]:
> > > From: Andrzej Zaborowski <balrog@zabor.org>
> > >
> > > [Sorry, the previous patch was a copy/paste mistake, this one should be
> > > better]
> > >
> > > I have no access to the docs for this chip but I'm pretty sure the current
> > > address of the two DIDR1 registers is wrong because it's outside the
> > > TUSB-specific register space. The modified address in turn has a good
> > > chance to be correct.
> > >
> > > Signed-off-by: Andrzej Zaborowski <balrog@zabor.org>
> > > ---
> > > drivers/usb/musb/tusb6010.h | 4 ++--
> > > 1 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/usb/musb/tusb6010.h b/drivers/usb/musb/tusb6010.h
> > > index bb25c3b..f2036ef 100644
> > > --- a/drivers/usb/musb/tusb6010.h
> > > +++ b/drivers/usb/musb/tusb6010.h
> > > @@ -225,8 +225,8 @@ extern void tusb_allow_idle(struct musb *musb, u32 wakeup_enables);
> > > #define TUSB_PROD_TEST_RESET_VAL 0xa596
> > > #define TUSB_EP_FIFO(ep) (TUSB_FIFO_BASE + (ep) * 0x20)
> > >
> > > -#define TUSB_DIDR1_LO 0x1f8
> > > -#define TUSB_DIDR1_HI 0x1fc
> > > +#define TUSB_DIDR1_LO (TUSB_SYS_REG_BASE + 0x1f8)
> > > +#define TUSB_DIDR1_HI (TUSB_SYS_REG_BASE + 0x1fc)
> > > #define TUSB_DIDR1_HI_CHIP_REV(v) (((v) >> 17) & 0xf)
> > > #define TUSB_DIDR1_HI_REV_20 0
> > > #define TUSB_DIDR1_HI_REV_30 1
> >
> > This looks like a valid fix. Hmm, I guess we've had some unnecessary
> > software workarounds for tusb3.1 chips happening :)
>
>
> Ugh, I'm out for today and tomorrow but I'll test on wednesday and make
> sure it works.
Thanks.
I only checked with usb-net, the only difference was that I got
"dieid2" instead of "dieid5" in the dmesg (2 seems correct for
rev3.1). The machine is some n810 proto (says N00).
Cheers
--
Please do not print this email unless absolutely necessary. Spread
environmental awareness.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Fix TUSB6010 ID register offsets.
2008-03-29 17:52 [PATCH] Fix TUSB6010 ID register offsets Andrzej Zaborowski
2008-03-31 7:58 ` Tony Lindgren
@ 2008-04-02 10:15 ` Felipe Balbi
2008-04-02 10:46 ` Tony Lindgren
1 sibling, 1 reply; 7+ messages in thread
From: Felipe Balbi @ 2008-04-02 10:15 UTC (permalink / raw)
To: Andrzej Zaborowski; +Cc: linux-omap
On Sat, 29 Mar 2008 18:52:16 +0100, Andrzej Zaborowski <balrogg@gmail.com>
wrote:
> From: Andrzej Zaborowski <balrog@zabor.org>
>
> [Sorry, the previous patch was a copy/paste mistake, this one should be
> better]
>
> I have no access to the docs for this chip but I'm pretty sure the
current
> address of the two DIDR1 registers is wrong because it's outside the
> TUSB-specific register space. The modified address in turn has a good
> chance to be correct.
>
> Signed-off-by: Andrzej Zaborowski <balrog@zabor.org>
Acked-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
> drivers/usb/musb/tusb6010.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/musb/tusb6010.h b/drivers/usb/musb/tusb6010.h
> index bb25c3b..f2036ef 100644
> --- a/drivers/usb/musb/tusb6010.h
> +++ b/drivers/usb/musb/tusb6010.h
> @@ -225,8 +225,8 @@ extern void tusb_allow_idle(struct musb *musb, u32
> wakeup_enables);
> #define TUSB_PROD_TEST_RESET_VAL 0xa596
> #define TUSB_EP_FIFO(ep) (TUSB_FIFO_BASE + (ep) * 0x20)
>
> -#define TUSB_DIDR1_LO 0x1f8
> -#define TUSB_DIDR1_HI 0x1fc
> +#define TUSB_DIDR1_LO (TUSB_SYS_REG_BASE + 0x1f8)
> +#define TUSB_DIDR1_HI (TUSB_SYS_REG_BASE + 0x1fc)
> #define TUSB_DIDR1_HI_CHIP_REV(v) (((v) >> 17) & 0xf)
> #define TUSB_DIDR1_HI_REV_20 0
> #define TUSB_DIDR1_HI_REV_30 1
> --
> 1.5.3.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Best Regards,
Felipe Balbi
http://felipebalbi.com
me@felipebalbi.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Fix TUSB6010 ID register offsets.
2008-04-02 10:15 ` Felipe Balbi
@ 2008-04-02 10:46 ` Tony Lindgren
0 siblings, 0 replies; 7+ messages in thread
From: Tony Lindgren @ 2008-04-02 10:46 UTC (permalink / raw)
To: Felipe Balbi; +Cc: Andrzej Zaborowski, linux-omap
* Felipe Balbi <me@felipebalbi.com> [080402 13:15]:
>
>
> On Sat, 29 Mar 2008 18:52:16 +0100, Andrzej Zaborowski <balrogg@gmail.com>
> wrote:
> > From: Andrzej Zaborowski <balrog@zabor.org>
> >
> > [Sorry, the previous patch was a copy/paste mistake, this one should be
> > better]
> >
> > I have no access to the docs for this chip but I'm pretty sure the
> current
> > address of the two DIDR1 registers is wrong because it's outside the
> > TUSB-specific register space. The modified address in turn has a good
> > chance to be correct.
> >
> > Signed-off-by: Andrzej Zaborowski <balrog@zabor.org>
> Acked-by: Felipe Balbi <felipe.balbi@nokia.com>
Pushed.
Tony
> > ---
> > drivers/usb/musb/tusb6010.h | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/usb/musb/tusb6010.h b/drivers/usb/musb/tusb6010.h
> > index bb25c3b..f2036ef 100644
> > --- a/drivers/usb/musb/tusb6010.h
> > +++ b/drivers/usb/musb/tusb6010.h
> > @@ -225,8 +225,8 @@ extern void tusb_allow_idle(struct musb *musb, u32
> > wakeup_enables);
> > #define TUSB_PROD_TEST_RESET_VAL 0xa596
> > #define TUSB_EP_FIFO(ep) (TUSB_FIFO_BASE + (ep) * 0x20)
> >
> > -#define TUSB_DIDR1_LO 0x1f8
> > -#define TUSB_DIDR1_HI 0x1fc
> > +#define TUSB_DIDR1_LO (TUSB_SYS_REG_BASE + 0x1f8)
> > +#define TUSB_DIDR1_HI (TUSB_SYS_REG_BASE + 0x1fc)
> > #define TUSB_DIDR1_HI_CHIP_REV(v) (((v) >> 17) & 0xf)
> > #define TUSB_DIDR1_HI_REV_20 0
> > #define TUSB_DIDR1_HI_REV_30 1
> > --
> > 1.5.3.4
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> Best Regards,
>
> Felipe Balbi
> http://felipebalbi.com
> me@felipebalbi.com
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-04-02 10:46 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-29 17:52 [PATCH] Fix TUSB6010 ID register offsets Andrzej Zaborowski
2008-03-31 7:58 ` Tony Lindgren
2008-03-31 8:58 ` Felipe Balbi
2008-03-31 12:52 ` andrzej zaborowski
2008-04-02 10:15 ` Felipe Balbi
2008-04-02 10:46 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2008-03-29 17:01 Andrzej Zaborowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox