From: Tony Lindgren <tony@atomide.com>
To: linux-omap@vger.kernel.org
Cc: Tony Lindgren <tony@atomide.com>
Subject: [PATCH 2/3] CBUS: Checkpatch.pl fixes for retu-wdt.c
Date: Mon, 12 May 2008 17:35:17 -0700 [thread overview]
Message-ID: <1210638918-26644-3-git-send-email-tony@atomide.com> (raw)
In-Reply-To: <1210638918-26644-2-git-send-email-tony@atomide.com>
Checkpatch.pl fixes for retu-wdt.c
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
drivers/cbus/retu-wdt.c | 24 ++++++++++++++----------
1 files changed, 14 insertions(+), 10 deletions(-)
diff --git a/drivers/cbus/retu-wdt.c b/drivers/cbus/retu-wdt.c
index 85202ef..b7b20b7 100644
--- a/drivers/cbus/retu-wdt.c
+++ b/drivers/cbus/retu-wdt.c
@@ -42,7 +42,8 @@
static struct completion retu_wdt_completion;
static DEFINE_MUTEX(retu_wdt_mutex);
-static unsigned int period_val = RETU_WDT_DEFAULT_TIMER; /* Current period of watchdog */
+/* Current period of watchdog */
+static unsigned int period_val = RETU_WDT_DEFAULT_TIMER;
static int counter_param = RETU_WDT_MAX_TIMER;
static int retu_modify_counter(unsigned int new)
@@ -61,15 +62,16 @@ static int retu_modify_counter(unsigned int new)
return ret;
}
-static ssize_t retu_wdt_period_show(struct device *dev, struct device_attribute *attr,
- char *buf)
+static ssize_t retu_wdt_period_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
{
/* Show current max counter */
return sprintf(buf, "%u\n", (u16)period_val);
}
-static ssize_t retu_wdt_period_store(struct device *dev, struct device_attribute *attr,
- const char *buf, size_t count)
+static ssize_t retu_wdt_period_store(struct device *dev,
+ struct device_attribute *attr,
+ const char *buf, size_t count)
{
unsigned int new_period;
int ret;
@@ -86,8 +88,8 @@ static ssize_t retu_wdt_period_store(struct device *dev, struct device_attribute
return strnlen(buf, count);
}
-static ssize_t retu_wdt_counter_show(struct device *dev, struct device_attribute *attr,
- char *buf)
+static ssize_t retu_wdt_counter_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
{
u16 counter;
@@ -99,7 +101,7 @@ static ssize_t retu_wdt_counter_show(struct device *dev, struct device_attribute
}
static DEVICE_ATTR(period, S_IRUGO | S_IWUSR, retu_wdt_period_show, \
- retu_wdt_period_store);
+ retu_wdt_period_store);
static DEVICE_ATTR(counter, S_IRUGO, retu_wdt_counter_show, NULL);
static int __devinit retu_wdt_probe(struct device *dev)
@@ -108,14 +110,16 @@ static int __devinit retu_wdt_probe(struct device *dev)
ret = device_create_file(dev, &dev_attr_period);
if (ret) {
- printk(KERN_ERR "retu_wdt_probe: Error creating sys device file: period\n");
+ printk(KERN_ERR "retu_wdt_probe: Error creating "
+ "sys device file: period\n");
return ret;
}
ret = device_create_file(dev, &dev_attr_counter);
if (ret) {
device_remove_file(dev, &dev_attr_period);
- printk(KERN_ERR "retu_wdt_probe: Error creating sys device file: counter\n");
+ printk(KERN_ERR "retu_wdt_probe: Error creating "
+ "sys device file: counter\n");
}
return ret;
--
1.5.3.6
next prev parent reply other threads:[~2008-05-13 0:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 0:35 [PATCH 0/3] Retu watchdog clean-up and fix to make it behave Tony Lindgren
2008-05-13 0:35 ` [PATCH 1/3] CBUS: Fix retu mutex handling Tony Lindgren
2008-05-13 0:35 ` Tony Lindgren [this message]
2008-05-13 0:35 ` [PATCH 3/3] CBUS: Make retu watchdog behave like a standard Linux watchdog Tony Lindgren
2008-05-13 0:46 ` Igor Stoppa
2008-05-13 1:17 ` Tony Lindgren
2008-05-15 21:46 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210638918-26644-3-git-send-email-tony@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox