Re: [PATCH 3/3] CBUS: Make retu watchdog behave like a standard Linux watchdog

[Igor Stoppa <igor.stoppa@nokia.com>]

Hi Tony,
On Mon, 2008-05-12 at 17:35 -0700, ext Tony Lindgren wrote:
> Make retu watchdog behave like a standard Linux watchdog.
> 
> Let the kernel do the kicking until the watchdog device is opened.

This is not always the desidered behavior: the powerdown wd is used to
ensure that the whole sw stack is healty: doing the kicking in
kernelspace for free introduces the case where userspace can get stuck
and the device does not powerdown.

Also the unconditional loading of the maximum value during probe is not
aligned with the original reset logic, which was to have the powerdown
wd to allow for 2 boot attempts:

-cold boot -> load max value in retu wd (63s)
           -> load 30s in omap wd
-try to kick both wds

if fail, then omap reboots, but retu keeps counting down

-warm boot -> let the retu wd untouched
           -> load 30s in omap wd
-try to kick both wds

if fail, retu powers down

That was the original idea in 770 times and i still like it.

To conclude, i'd see inkernel kicking more as a debugging feature while
one is hacking at the kernel than a desirable quality of a stable
kernel.

-- 
Cheers, Igor

---

Igor Stoppa
Nokia Devices R&D - Helsinki
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html