Re: [PATCH 5/5] ARM: OMAP: remove unnecessary locking in clk_get_rate()

Kevin Hilman
2008-06-04T16:35:28Z

Paul Walmsley wrote:
>
> Hi Kevin,
>
> On Tue, 20 May 2008, Kevin Hilman wrote:
>
> > The locking in the get_rate() hook is unnecessary, and causes problems
> > when used with the -rt patch, since it may be called recursively.
> >
> > Signed-off-by: Kevin Hilman <khilman@mvista.com>
>
> Acked-by: Paul Walmsley <paul@pwsan.com>
>
> BTW, looks like we could probably get rid of some of the other spinlocking
> in plat-omap/clock.c also -- clk_get_usecount() ?

I agree, most of the locking in there seems unnecessary, but this was
the only one that could be removed without looking closer at at all the
platform specific clock code.

Basically, I think there minimal (maybe no) locking in the generic
layer, and the locking should be done if necessary in the platform
specific parts.

Kevin