public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: linux-arm-kernel@lists.arm.linux.org.uk
Cc: Tony Lindgren <tony@atomide.com>,
	linux-omap@vger.kernel.org,
	Jarkko Nikula <jarkko.nikula@nokia.com>
Subject: [PATCH 01/02] ARM: OMAP: DMA: Don't mark channel active in omap_enable_channel_irq
Date: Fri,  6 Jun 2008 18:21:47 -0700	[thread overview]
Message-ID: <1212801708-17599-2-git-send-email-tony@atomide.com> (raw)
Message-ID: v2.6.26-rc5-omap-fixes-1-2
In-Reply-To: <1212801708-17599-1-git-send-email-tony@atomide.com>

From: Jarkko Nikula <jarkko.nikula@nokia.com>

Channel should be marked active only when DMA is really started. Otherwise
just omap_request_dma, omap_dma_link_lch and omap_dma_unlink_lch will cause
incorrect dump_stack().

Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>

diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
index c00eda5..39c637b 100644
--- a/arch/arm/plat-omap/dma.c
+++ b/arch/arm/plat-omap/dma.c
@@ -501,8 +501,6 @@ static inline void omap_enable_channel_irq(int lch)
 
 	/* Enable some nice interrupts. */
 	OMAP_DMA_CICR_REG(lch) = dma_chan[lch].enabled_irqs;
-
-	dma_chan[lch].flags |= OMAP_DMA_ACTIVE;
 }
 
 static void omap_disable_channel_irq(int lch)

-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php

  reply	other threads:[~2008-06-07  1:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <omap-fixes-20080607181939-0-2>
2008-06-07  1:21 ` [PATCH 00/02] Git pull request for 2.6.26 for two omap fixes Tony Lindgren
     [not found]   ` <v2.6.26-rc5-omap-fixes-1-2>
2008-06-07  1:21     ` Tony Lindgren [this message]
     [not found]       ` <v2.6.26-rc5-omap-fixes-2-2>
2008-06-07  1:21         ` [PATCH 02/02] ARM: OMAP: Correcting the gpmc prefetch control register address Tony Lindgren
2008-06-14  8:00       ` Russell King - ARM Linux
2008-06-14  8:02       ` Russell King - ARM Linux
2008-06-14  8:00   ` [PATCH 01/02] ARM: OMAP: DMA: Don't mark channel active in omap_enable_channel_irq Russell King - ARM Linux
2008-06-14  8:02   ` Russell King - ARM Linux
2008-06-16  9:59     ` Tony Lindgren
2008-06-22 14:03       ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1212801708-17599-2-git-send-email-tony@atomide.com \
    --to=tony@atomide.com \
    --cc=jarkko.nikula@nokia.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox