Re: [PATCH 3/3] radio-tea5761: Update driver

Felipe Balbi
2008-06-10T02:07:26Z

On Mon, Jun 09, 2008 at 09:14:21PM -0400, Eduardo Valentin wrote:
> If I understood correctly what you said, the same comment I said
> before also applies here.
> Eventhough it prints that the probe
> failed, this way I sent it says: The probe failed and "The driver
> registration failed". More easy
> to debug the code when in a error situation.

But if probe fails, driver registration failed. The same comment Jean
Delvare gave me when I was sending some isp1301 patches upstream, so
later on, when this driver goes to mailine, it'll probably, if Jean
happens to see this one, get commented on this point as well.

If you look at drivers/i2c/chips/*.c you'll see that only in two cases
they are printing error if i2c_add_driver() fails and those are really
necessary cases (check those drivers).

But anyway, if you think it's really necessary.

--
Best Regards,

Felipe Balbi
me@felipebalbi.com