public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Kalle Jokiniemi <ext-kalle.jokiniemi@nokia.com>
To: linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP3: Remove CONFIG_OMAP_SYSOFFMODE flag
Date: Thu, 28 Aug 2008 16:09:47 +0300	[thread overview]
Message-ID: <1219928987.6269.1.camel@kj-ubuntu> (raw)
In-Reply-To: <1219755620-9773-1-git-send-email-ext-kalle.jokiniemi@nokia.com>

On ti, 2008-08-26 at 16:00 +0300, Kalle Jokiniemi wrote:
> Remove CONFIG_OMAP_SYSOFFMODE flag and do the full initialization of voltage
> controller . Enabling automatic sending of OFF command and selecting wether
> SYS_OFF_MODE signal is used should be determined dynamically. Hence they are
> now not set in the initialization.

This patch needs to be added with safer off-mode sleep voltage settings.
Please disregard, whis one. I'll send a new one with couple of other
patches soon.

regards,
Kalle

> 
> Signed-off-by: Kalle Jokiniemi <ext-kalle.jokiniemi@nokia.com>
> ---
>  arch/arm/mach-omap2/pm34xx.c |   10 +---------
>  1 files changed, 1 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> index a16eb33..5633753 100644
> --- a/arch/arm/mach-omap2/pm34xx.c
> +++ b/arch/arm/mach-omap2/pm34xx.c
> @@ -623,10 +623,7 @@ static void __init configure_vc(void)
>  				OMAP3_PRM_VC_I2C_CFG_OFFSET);
>  
>  	/* Setup voltctrl and other setup times */
> -
> -#ifdef CONFIG_OMAP_SYSOFFMODE
> -	prm_write_mod_reg(OMAP3430_AUTO_OFF | OMAP3430_AUTO_RET |
> -			OMAP3430_SEL_OFF, OMAP3430_GR_MOD,
> +	prm_write_mod_reg(OMAP3430_AUTO_RET, OMAP3430_GR_MOD,
>  			OMAP3_PRM_VOLTCTRL_OFFSET);
>  
>  	prm_write_mod_reg(OMAP3430_CLKSETUP_DURATION, OMAP3430_GR_MOD,
> @@ -641,11 +638,6 @@ static void __init configure_vc(void)
>  			OMAP3_PRM_VOLTOFFSET_OFFSET);
>  	prm_write_mod_reg(OMAP3430_VOLTSETUP2_DURATION, OMAP3430_GR_MOD,
>  			OMAP3_PRM_VOLTSETUP2_OFFSET);
> -#else
> -	prm_set_mod_reg_bits(OMAP3430_AUTO_RET, OMAP3430_GR_MOD,
> -			OMAP3_PRM_VOLTCTRL_OFFSET);
> -#endif
> -
>  }
>  
>  static int __init omap3_pm_early_init(void)

  reply	other threads:[~2008-08-28 13:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-26 13:00 [PATCH] OMAP3: Remove CONFIG_OMAP_SYSOFFMODE flag Kalle Jokiniemi
2008-08-28 13:09 ` Kalle Jokiniemi [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-10-17  6:46 Kalle Jokiniemi
2008-10-24 10:50 ` Kalle Jokiniemi
2008-10-24 19:22   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1219928987.6269.1.camel@kj-ubuntu \
    --to=ext-kalle.jokiniemi@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox