From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: [PATCH 2/4] SOUND: SOC: CODECS: Add support for the TWL4030 audio codec Date: Tue, 02 Sep 2008 21:08:09 +0100 Message-ID: <1220386089.6499.223.camel@odin> References: <1220306279-27977-1-git-send-email-sakoman@gmail.com> <1220306279-27977-2-git-send-email-sakoman@gmail.com> <1220306279-27977-3-git-send-email-sakoman@gmail.com> <20080902112633.GB25176@sirena.org.uk> <5e088bd90809020725g1d0dff70ue84f861ea3e22201@mail.gmail.com> <20080902145328.GA3764@rakim.wolfsonmicro.main> <5e088bd90809020936i2d5e8a12lee33acfe5cbd8cd6@mail.gmail.com> <20080902185432.GA3553@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080902185432.GA3553@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Steve Sakoman , alsa-devel@alsa-project.org, linux-omap@vger.kernel.org List-Id: linux-omap@vger.kernel.org On Tue, 2008-09-02 at 19:54 +0100, Mark Brown wrote: > On Tue, Sep 02, 2008 at 09:36:29AM -0700, Steve Sakoman wrote: > > > The chip allows 19.2 Mhz, 26 Mhz, or 38.4 Mhz input clocks to the > > codec. All existing boards (Overo, Beagle, and OMAP3 EVM) use 26 Mhz > > (generated by a fixed external oscillator chip). I'll check with the > > Pandora folks, but I believe that they are also 26 Mhz. > > OK, a comment to that effect somewhere (perhaps in set_sysclk() which > only accepts 26MHz) probably wouldn't go amiss. The codec set_sysclk() should also accept 19.2MHz and 38.4MHz otherwise return -EINVAL. It should also have a nice comment too :) Strange how the codec doesn't accept lower clocks when it's targeted at a portable device.... Liam