From: Steve Sakoman <steve@sakoman.com>
To: David Brownell <david-b@pacbell.net>
Cc: Tony Lindgren <tony@atomide.com>, linux-omap@vger.kernel.org
Subject: Re: [patch 2.6.27-rc6-omap] ASOC: quieter boot for non-Overo boards
Date: Thu, 25 Sep 2008 10:07:31 -0700 [thread overview]
Message-ID: <1222362451.24304.59.camel@tera.sakoman.net> (raw)
In-Reply-To: <200809250950.06409.david-b@pacbell.net>
On Thu, 2008-09-25 at 09:50 -0700, David Brownell wrote:
> On Thursday 25 September 2008, Tony Lindgren wrote:
> > > Get rid of bogus ASOC boot messages on non-Overo boards.
> >
> > I'm not touching this without an ack from alsa list :)
>
> Has this driver even gone to that list yet? ;)
Yes, the initial submission was reviewed and acked by folks on
alsa-devel.
And now that I think of it, this code should never execute on non-overo
boards since they will have their own machine ASoC driver! So this
patch isn't really necessary.
> I haven't really looked at initialization for this yet,
> but my initial reaction to seeing the Beagle's version
> of the overo.c file is that more sharing should exist.
> (Wasn't the beagle ASOC init described as a clone?)
This was discussed, but since the overo has some additional
functionality that will be added to the machine portion of the driver it
was decided to have separate machine files for overo and beagle. I'm
waiting for an overo "buddy" board that brings out the additional
microphone inputs before I can add and test this functionality.
> And then ... that, hey, this should hook into the same
> MFD-style initialization as we're making the other
> twl4030 code use.
>
> And finally ... whoa, maybe someone else can split
> out the board-specific bits so they can be put in
> the arch/arm/mach-omap2/board-XYZ.c files, since I'd
> surely lose a lot of time learning ASOC if I were
> to start that! (These messages are right at the
> core of that bit.)
Putting the board specific bits in the arch/arm/mach-omap2/board-XYZ.c
file has been discussed a number of times on alsa-devel and the folks
there insist that for now (i.e. ASoC V1) this is the proper way to do
things.
Steve
next prev parent reply other threads:[~2008-09-25 17:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-21 21:14 [patch 2.6.27-rc6-omap] ASOC: quieter boot for non-Overo boards David Brownell
2008-09-25 12:49 ` Tony Lindgren
2008-09-25 16:50 ` David Brownell
2008-09-25 17:07 ` Steve Sakoman [this message]
2008-09-25 17:41 ` David Brownell
2008-09-26 7:37 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222362451.24304.59.camel@tera.sakoman.net \
--to=steve@sakoman.com \
--cc=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox