public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <me@felipebalbi.com>
To: linux-omap@vger.kernel.org
Cc: Felipe Balbi <felipe.balbi@nokia.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: [PATCH 1/7] input: lm8323: get rid of global pdata pointer
Date: Wed, 15 Oct 2008 00:39:51 +0300	[thread overview]
Message-ID: <1224020397-2842-2-git-send-email-me@felipebalbi.com> (raw)
In-Reply-To: <1224020397-2842-1-git-send-email-me@felipebalbi.com>

From: Felipe Balbi <felipe.balbi@nokia.com>

pdata is only used during probe to initialize a few fields
from lm8323 device structure. Moving pdata pointer to probe
won't harm anybody.

Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
---
 drivers/input/keyboard/lm8323.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/input/keyboard/lm8323.c b/drivers/input/keyboard/lm8323.c
index 72bb587..b6f464c 100644
--- a/drivers/input/keyboard/lm8323.c
+++ b/drivers/input/keyboard/lm8323.c
@@ -184,9 +184,6 @@ static struct lm8323_chip *pwm_to_lm8323(struct lm8323_pwm *pwm)
 	}
 }
 
-static struct lm8323_platform_data *lm8323_pdata;
-
-
 #define LM8323_MAX_DATA 8
 
 /*
@@ -673,6 +670,7 @@ static DEVICE_ATTR(disable_kp, 0644, lm8323_show_disable, lm8323_set_disable);
 static int lm8323_probe(struct i2c_client *client,
 					const struct i2c_device_id *id)
 {
+	struct lm8323_platform_data *lm8323_pdata;
 	struct input_dev *idev;
 	struct lm8323_chip *lm;
 	int i, err = 0;
-- 
1.6.0.2.307.gc427


  reply	other threads:[~2008-10-14 21:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-14 21:39 [PATCH 0/7] updates to few nokia drivers Felipe Balbi
2008-10-14 21:39 ` Felipe Balbi [this message]
2008-10-14 21:39   ` [PATCH 2/7] input: tsc2005: move to gpiolib Felipe Balbi
2008-10-14 21:39     ` [PATCH 3/7] i2c: lp5521: remove dead code Felipe Balbi
2008-10-14 21:39       ` [PATCH 4/7] i2c: lp5521: cosmetic fixes Felipe Balbi
2008-10-14 21:39         ` [PATCH 5/7] i2c: lp5521: simplify mode setting Felipe Balbi
2008-10-14 21:39           ` [PATCH 6/7] i2c: lp5521: move to LED framework Felipe Balbi
2008-10-14 21:39             ` [PATCH 7/7] leds: lp5521: move to drivers/leds Felipe Balbi
2008-10-14 23:20     ` [PATCH 2/7] input: tsc2005: move to gpiolib David Brownell
2008-10-15  7:43       ` Felipe Balbi
2008-10-15 10:21       ` Felipe Balbi
2008-10-16  4:10   ` [PATCH 1/7] input: lm8323: get rid of global pdata pointer Dmitry Torokhov
2008-10-16  8:39     ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1224020397-2842-2-git-send-email-me@felipebalbi.com \
    --to=me@felipebalbi.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=felipe.balbi@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox